From 08a11127aafde5c64de7e1d6a9cd1383c4ff07e6 Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 22 Sep 2021 08:37:41 -0700 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/21294: change `when (condition) {` `when {` in Fact.toEvent. This will not compile. However, it enables the subsequent PR to remove allocations from Fact.toEvent. --- .../org/mozilla/fenix/components/metrics/MetricController.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt index 5b4cb2e541..d7e7566665 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/MetricController.kt @@ -158,7 +158,7 @@ internal class ReleaseMetricController( } @Suppress("LongMethod") - private fun Fact.toEvent(): Event? = when (Pair(component, item)) { + private fun Fact.toEvent(): Event? = when { Component.FEATURE_PROMPTS to LoginDialogFacts.Items.DISPLAY -> Event.LoginDialogPromptDisplayed Component.FEATURE_PROMPTS to LoginDialogFacts.Items.CANCEL -> Event.LoginDialogPromptCancelled Component.FEATURE_PROMPTS to LoginDialogFacts.Items.NEVER_SAVE -> Event.LoginDialogPromptNeverSave