From 07742ec701855c2c910a1616d6a5343dcf2d9fe8 Mon Sep 17 00:00:00 2001 From: Arturo Mejia Date: Tue, 26 Oct 2021 10:26:06 -0400 Subject: [PATCH] [fenix] For https://github.com/mozilla-mobile/fenix/issues/22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close --- .../browser/InactiveTabsAutoCloseDialogController.kt | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAutoCloseDialogController.kt b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAutoCloseDialogController.kt index f7175328e..599f62fd7 100644 --- a/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAutoCloseDialogController.kt +++ b/app/src/main/java/org/mozilla/fenix/tabstray/browser/InactiveTabsAutoCloseDialogController.kt @@ -20,7 +20,7 @@ class InactiveTabsAutoCloseDialogController( * Dismiss the auto-close dialog. */ fun close() { - settings.hasInactiveTabsAutoCloseDialogBeenDismissed = true + markDialogAsShown() refeshInactiveTabsSecion() } @@ -28,7 +28,7 @@ class InactiveTabsAutoCloseDialogController( * Enable the auto-close feature with the after a month setting. */ fun enableAutoClosed() { - settings.hasInactiveTabsAutoCloseDialogBeenDismissed = true + markDialogAsShown() settings.closeTabsAfterOneMonth = true settings.closeTabsAfterOneWeek = false settings.closeTabsAfterOneDay = false @@ -36,6 +36,13 @@ class InactiveTabsAutoCloseDialogController( refeshInactiveTabsSecion() } + /** + * Marks the dialog as shown and to not be displayed again. + */ + private fun markDialogAsShown() { + settings.hasInactiveTabsAutoCloseDialogBeenDismissed = true + } + @VisibleForTesting internal fun refeshInactiveTabsSecion() { val tabs = browserStore.state.tabs.filter(tabFilter)