No issue: cache SearchDialogFragment.InlineAutocompleteEditText.

Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
upstream-sync
Michael Comella 3 years ago committed by mergify[bot]
parent 34ca959661
commit 01e3b4b984

@ -83,6 +83,7 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
private lateinit var interactor: SearchDialogInteractor
private lateinit var store: SearchDialogFragmentStore
private lateinit var toolbarView: ToolbarView
private lateinit var inlineAutocompleteEditText: InlineAutocompleteEditText
private lateinit var awesomeBarView: AwesomeBarView
private val qrFeature = ViewBoundFeatureWrapper<QrFeature>()
@ -176,9 +177,7 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
},
focusToolbar = { toolbarView.view.edit.focus() },
clearToolbar = {
toolbarView.view
.findViewById<InlineAutocompleteEditText>(R.id.mozac_browser_toolbar_edit_url_view)
?.setText("")
inlineAutocompleteEditText.setText("")
}
)
)
@ -194,7 +193,9 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
binding.toolbar,
requireComponents.core.engine,
fromHomeFragment
)
).also {
inlineAutocompleteEditText = it.view.findViewById(R.id.mozac_browser_toolbar_edit_url_view)
}
val awesomeBar = binding.awesomeBar
@ -212,9 +213,7 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
awesomeBarView.view.setOnEditSuggestionListener(toolbarView.view::setSearchTerms)
val urlView = toolbarView.view
.findViewById<InlineAutocompleteEditText>(R.id.mozac_browser_toolbar_edit_url_view)
urlView?.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_NO
inlineAutocompleteEditText.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_NO
requireComponents.core.engine.speculativeCreateSession(isPrivate)
@ -666,14 +665,11 @@ class SearchDialogFragment : AppCompatDialogFragment(), UserInteractionHandler {
}
private fun updateToolbarContentDescription(source: SearchEngineSource) {
val urlView = toolbarView.view
.findViewById<InlineAutocompleteEditText>(R.id.mozac_browser_toolbar_edit_url_view)
source.searchEngine?.let { engine ->
toolbarView.view.contentDescription = engine.name + ", " + urlView.hint
toolbarView.view.contentDescription = engine.name + ", " + inlineAutocompleteEditText.hint
}
urlView?.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_NO
inlineAutocompleteEditText.importantForAccessibility = View.IMPORTANT_FOR_ACCESSIBILITY_NO
}
private fun updateSearchShortcutsIcon(

Loading…
Cancel
Save