From 0082e3208887a4cae5f39010f46a379bae4dcbfd Mon Sep 17 00:00:00 2001
From: Adam Novak <interfect@gmail.com>
Date: Sun, 8 Nov 2020 16:53:33 -0800
Subject: [PATCH] Suppress Mozilla's new lint errors

---
 .../components/PagedAddonInstallationDialogFragment.kt        | 4 ++++
 .../iceraven/components/PagedAddonsManagerAdapter.kt          | 4 ++++
 app/src/main/res/layout/component_tabs_screen_bottom.xml      | 2 ++
 app/src/main/res/layout/component_tabs_screen_top.xml         | 2 ++
 app/src/main/res/layout/component_tabstray_bottom.xml         | 2 ++
 app/src/main/res/layout/component_tabstray_top.xml            | 2 ++
 6 files changed, 16 insertions(+)

diff --git a/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonInstallationDialogFragment.kt b/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonInstallationDialogFragment.kt
index 8ce89ec23..de08c70a5 100644
--- a/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonInstallationDialogFragment.kt
+++ b/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonInstallationDialogFragment.kt
@@ -53,6 +53,10 @@ private const val DEFAULT_VALUE = Int.MAX_VALUE
 /**
  * A dialog that shows [Addon] installation confirmation.
  */
+// We have an extra "Lint" Android Studio linter pass that Android Components
+// where the original code came from doesn't. So we tell it to ignore us. Make
+// sure to keep up with changes in Android Components though.
+@SuppressLint("all")
 class PagedAddonInstallationDialogFragment : AppCompatDialogFragment() {
     private val scope = CoroutineScope(Dispatchers.IO)
     @VisibleForTesting internal var iconJob: Job? = null
diff --git a/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonsManagerAdapter.kt b/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonsManagerAdapter.kt
index 0e2355e5c..a6f319f2b 100644
--- a/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonsManagerAdapter.kt
+++ b/app/src/main/java/io/github/forkmaintainers/iceraven/components/PagedAddonsManagerAdapter.kt
@@ -58,6 +58,10 @@ private const val VIEW_HOLDER_TYPE_ADDON = 2
  * @property style Indicates how items should look like.
  */
 @Suppress("TooManyFunctions", "LargeClass")
+// We have an extra "Lint" Android Studio linter pass that Android Components
+// where the original code came from doesn't. So we tell it to ignore us. Make
+// sure to keep up with changes in Android Components though.
+@SuppressLint("all")
 class PagedAddonsManagerAdapter(
     private val addonCollectionProvider: PagedAddonCollectionProvider,
     private val addonsManagerDelegate: AddonsManagerAdapterDelegate,
diff --git a/app/src/main/res/layout/component_tabs_screen_bottom.xml b/app/src/main/res/layout/component_tabs_screen_bottom.xml
index b38886e5c..90ccc3cf7 100644
--- a/app/src/main/res/layout/component_tabs_screen_bottom.xml
+++ b/app/src/main/res/layout/component_tabs_screen_bottom.xml
@@ -25,6 +25,7 @@
 
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/infoBanner"
         android:visibility="gone"
         android:layout_width="match_parent"
@@ -48,6 +49,7 @@
         app:layout_constraintBottom_toTopOf="@id/infoBanner" />
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/topBar"
         android:layout_width="match_parent"
         android:layout_height="50dp"
diff --git a/app/src/main/res/layout/component_tabs_screen_top.xml b/app/src/main/res/layout/component_tabs_screen_top.xml
index bdd61d944..6a0326b76 100644
--- a/app/src/main/res/layout/component_tabs_screen_top.xml
+++ b/app/src/main/res/layout/component_tabs_screen_top.xml
@@ -25,6 +25,7 @@
 
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/infoBanner"
         android:visibility="gone"
         android:layout_width="match_parent"
@@ -49,6 +50,7 @@
         app:layout_constraintTop_toBottomOf="@id/infoBanner" />
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/topBar"
         android:layout_width="match_parent"
         android:layout_height="50dp"
diff --git a/app/src/main/res/layout/component_tabstray_bottom.xml b/app/src/main/res/layout/component_tabstray_bottom.xml
index 2bb984ddc..aee3b4d62 100644
--- a/app/src/main/res/layout/component_tabstray_bottom.xml
+++ b/app/src/main/res/layout/component_tabstray_bottom.xml
@@ -25,6 +25,7 @@
 
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/infoBanner"
         android:visibility="gone"
         android:layout_width="match_parent"
@@ -49,6 +50,7 @@
         app:layout_constraintTop_toBottomOf="@id/infoBanner" />
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/topBar"
         android:layout_width="match_parent"
         android:layout_height="80dp"
diff --git a/app/src/main/res/layout/component_tabstray_top.xml b/app/src/main/res/layout/component_tabstray_top.xml
index 3761136b4..d7a29bee6 100644
--- a/app/src/main/res/layout/component_tabstray_top.xml
+++ b/app/src/main/res/layout/component_tabstray_top.xml
@@ -25,6 +25,7 @@
 
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts"
         android:id="@+id/infoBanner"
         android:visibility="gone"
         android:layout_width="match_parent"
@@ -48,6 +49,7 @@
         app:layout_constraintBottom_toTopOf="@id/infoBanner" />
 
     <androidx.constraintlayout.widget.ConstraintLayout
+        tools:ignore="MozMultipleConstraintLayouts" 
         android:id="@+id/topBar"
         android:layout_width="match_parent"
         android:layout_height="80dp"