From 0034bfdb0285cd621b6f22b8982cc78d83db8c85 Mon Sep 17 00:00:00 2001
From: Maurya Talisetti <mauryat@users.noreply.github.com>
Date: Wed, 24 Jul 2019 20:06:59 +0530
Subject: [PATCH] [fenix] Closes
 https://github.com/mozilla-mobile/fenix/issues/3419: Use better accessibility
 strings for tab collections

---
 app/src/main/res/layout/collection_home_list_row.xml | 4 ++--
 app/src/main/res/values/strings.xml                  | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/src/main/res/layout/collection_home_list_row.xml b/app/src/main/res/layout/collection_home_list_row.xml
index 0f6f38a38b..c144107e57 100644
--- a/app/src/main/res/layout/collection_home_list_row.xml
+++ b/app/src/main/res/layout/collection_home_list_row.xml
@@ -88,7 +88,7 @@
                 android:layout_marginStart="16dp"
                 android:layout_marginEnd="30dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
-                android:contentDescription="@string/share_header"
+                android:contentDescription="@string/share_button_content_description"
                 android:src="@drawable/ic_hollow_share"
                 app:layout_constraintEnd_toStartOf="@id/collection_overflow_button"
                 app:layout_constraintTop_toTopOf="@id/collection_icon" />
@@ -100,7 +100,7 @@
                 android:layout_marginTop="16dp"
                 android:layout_marginEnd="4.5dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
-                android:contentDescription="@string/tab_menu"
+                android:contentDescription="@string/collection_menu_button_content_description"
                 android:src="@drawable/ic_menu"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintTop_toTopOf="parent" />
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b81aba5bbd..9a4c72572f 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -492,6 +492,8 @@
     <!-- Collections -->
     <!-- Collections header on home fragment -->
     <string name="collections_header">Collections</string>
+    <!-- Content description (not visible, for screen readers etc.): Opens the collection menu when pressed -->
+    <string name="collection_menu_button_content_description">Collection menu</string>
     <!-- No Open Tabs Message Header -->
     <string name="no_collections_header">No collections</string>
     <!-- No Open Tabs Message Description -->
@@ -531,6 +533,9 @@
     <!-- Share -->
     <!-- Share screen header -->
     <string name="share_header">Send and Share</string>
+    <!-- Content description (not visible, for screen readers etc.):
+        "Share" button. Opens the share menu when pressed. -->
+    <string name="share_button_content_description">Share</string>
     <!-- Sub-header in the dialog to share a link to another app -->
     <string name="share_link_subheader">Share a link</string>
     <!-- Sub-header in the dialog to share a link to another sync device -->