2020-10-05 22:14:02 +00:00
<?xml version="1.0" encoding="UTF-8"?>
2021-09-11 11:38:13 +00:00
<issues format= "6" by= "lint 7.0.0" type= "baseline" client= "gradle" name= "AGP (7.0.0)" variant= "all" version= "7.0.0" >
2021-07-28 18:06:42 +00:00
<issue
id="IidCompatibilityCheckFailure"
message="Check failed with exception: java.lang.NoSuchMethodException: com.android.tools.lint.detector.api.LintModelModuleProject.getGradleProjectModel()">
<location
file="app"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" ?android:attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/account_preference.xml"
line="8"
column="5"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" ?android:attr/selectableItemBackground" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/collection_home_list_row.xml"
2021-12-06 21:33:33 +00:00
line="17"
2021-07-28 18:06:42 +00:00
column="5"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_collection_creation.xml"
line="144"
column="9"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
2021-12-06 21:33:33 +00:00
errorLine1=" android:foreground=" ?android:attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-09-11 11:38:13 +00:00
<location
2021-12-06 21:33:33 +00:00
file="src/main/res/layout/inactive_header_item.xml"
line="27"
column="9"/>
2021-09-11 11:38:13 +00:00
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
2021-12-06 21:33:33 +00:00
errorLine1=" android:foreground=" ?android:attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-09-11 11:38:13 +00:00
<location
2021-12-06 21:33:33 +00:00
file="src/main/res/layout/inactive_header_item.xml"
line="63"
column="13"/>
2021-09-11 11:38:13 +00:00
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
2021-12-06 21:33:33 +00:00
errorLine1=" android:foreground=" ?android:attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-12-06 21:33:33 +00:00
file="src/main/res/layout/inactive_tab_list_item.xml"
line="20"
column="9"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_theme_picker.xml"
2021-12-06 21:33:33 +00:00
line="70"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_theme_picker.xml"
2021-12-06 21:33:33 +00:00
line="98"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_theme_picker.xml"
2021-12-06 21:33:33 +00:00
line="147"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_toolbar_position_picker.xml"
2021-12-06 21:33:33 +00:00
line="60"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_toolbar_position_picker.xml"
2021-12-06 21:33:33 +00:00
line="114"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_tracking_protection.xml"
2021-12-06 21:33:33 +00:00
line="50"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" @drawable/rounded_ripple" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/onboarding_tracking_protection.xml"
2021-12-06 21:33:33 +00:00
line="71"
2021-07-28 18:06:42 +00:00
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutId` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutId=" open_new_tab" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="8"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutId` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutId=" open_new_tab" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="8"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutShortLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutShortLabel=" @string/home_screen_shortcut_open_new_tab_2" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="11"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutShortLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutShortLabel=" @string/home_screen_shortcut_open_new_tab_2" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="11"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutLongLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutLongLabel=" @string/home_screen_shortcut_open_new_tab_2" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="12"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutLongLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutLongLabel=" @string/home_screen_shortcut_open_new_tab_2" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="12"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutId` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutId=" open_new_private_tab" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="19"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutId` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutId=" open_new_private_tab" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="19"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutShortLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutShortLabel=" @string/home_screen_shortcut_open_new_private_tab_2" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="22"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutShortLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutShortLabel=" @string/home_screen_shortcut_open_new_private_tab_2" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="22"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutLongLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutLongLabel=" @string/home_screen_shortcut_open_new_private_tab_2" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/debug/res/xml/shortcuts.xml"
line="23"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `shortcutLongLabel` is only used in API level 25 and higher (current min is 21)"
errorLine1=" android:shortcutLongLabel=" @string/home_screen_shortcut_open_new_private_tab_2" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/xml/shortcuts.xml"
line="23"
column="9"/>
</issue>
<issue
id="UnusedAttribute"
message="Attribute `android:foreground` has no effect on API levels lower than 23 (current min is 21)"
errorLine1=" android:foreground=" ?android:selectableItemBackground" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/tab_tray_item.xml"
line="13"
column="5"/>
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VectorRaster"
message="Limit vector icons sizes to 200×
errorLine1=" android:width=" 1889dp" "
errorLine2=" ~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/res/drawable/ic_etp_artwork.xml"
line="7"
column="20"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" isInPrimaryState = { getCurrentTab()?.content?.canGoBack ?: false },"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="96"
2022-01-03 17:00:11 +00:00
column="38"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" isInPrimaryState = { getCurrentTab()?.content?.canGoForward ?: false },"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="118"
2022-01-03 17:00:11 +00:00
column="38"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" getCurrentTab()?.content?.loading == false"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="141"
2022-01-03 17:00:11 +00:00
column="21"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" if (getCurrentTab()?.content?.loading == true) {"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="155"
2022-01-03 17:00:11 +00:00
column="25"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" selected = getCurrentTab()?.let {"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="183"
2022-01-03 17:00:11 +00:00
column="28"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" getCurrentTab()?.let { tab ->"
errorLine2=" ~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt"
2022-02-10 19:00:59 +00:00
line="273"
2022-01-03 17:00:11 +00:00
column="9"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="VisibleForTests"
message="This method should only be accessed from tests or within private scope"
errorLine1=" tabsAction.updateCount(tabCount)"
errorLine2=" ~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt"
line="138"
column="20"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="ComposableNaming"
message="Composable functions with a return type should start with a lowercase letter"
errorLine1="fun EagerFlingBehavior("
errorLine2=" ~~~~~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/compose/LazyListEagerFlingBehavior.kt"
line="21"
column="5"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="UseCompatLoadingForDrawables"
message="Use `AppCompatResources.getDrawable()`"
errorLine1=" display.setUrlBackground(getDrawable(R.drawable.search_url_background))"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt"
line="89"
column="46"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="Typos"
message="" internett" is usually capitalized as " Internett" "
errorLine1=" < string name=" private_browsing_placeholder_description_2" >%1$s fjerner søk- og nettleserhistorikken fra private nettlesingsfaner når du lukker dem eller avslutter appen. Selv om dette ikke gjør deg anonym for nettsteder eller internett-leverandøren din, vil det gjøre det lettere"
errorLine2=" ^">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/res/values-nb-rNO/strings.xml"
line="71"
column="231"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2022-01-03 17:00:11 +00:00
id="Typos"
message="Repeated word " zaman" in message: possible typo"
errorLine1=" < string name=" studies_description" >Firefox zaman zaman araştı ı ı < /string>"
errorLine2=" ^">
2021-07-28 18:06:42 +00:00
<location
2022-01-03 17:00:11 +00:00
file="src/main/res/values-tr/strings.xml"
2022-02-10 19:00:59 +00:00
line="749"
2022-01-03 17:00:11 +00:00
column="48"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2021-09-11 11:38:13 +00:00
id="IntentFilterExportedReceiver"
message="When using intent filters, please specify `android:exported` as well"
errorLine1=" < activity-alias"
errorLine2=" ~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-09-11 11:38:13 +00:00
file="src/main/AndroidManifest.xml"
2022-02-10 19:00:59 +00:00
line="48"
2021-09-11 11:38:13 +00:00
column="10"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2021-09-11 11:38:13 +00:00
id="IntentFilterExportedReceiver"
message="When using intent filters, please specify `android:exported` as well"
errorLine1=" < activity-alias"
errorLine2=" ~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-09-11 11:38:13 +00:00
file="src/main/AndroidManifest.xml"
2022-02-10 19:00:59 +00:00
line="72"
2021-09-11 11:38:13 +00:00
column="10"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2021-09-11 11:38:13 +00:00
id="IntentFilterExportedReceiver"
message="When using intent filters, please specify `android:exported` as well"
errorLine1=" < activity"
errorLine2=" ~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-09-11 11:38:13 +00:00
file="src/main/AndroidManifest.xml"
2022-02-10 19:00:59 +00:00
line="80"
2021-09-11 11:38:13 +00:00
column="10"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
2021-09-11 11:38:13 +00:00
id="IntentFilterExportedReceiver"
message="When using intent filters, please specify `android:exported` as well"
errorLine1=" < service"
errorLine2=" ~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
2022-02-10 19:00:59 +00:00
line="273"
2021-09-11 11:38:13 +00:00
column="10"/>
</issue>
<issue
id="IntentFilterExportedReceiver"
message="When using intent filters, please specify `android:exported` as well"
errorLine1=" < receiver"
errorLine2=" ~~~~~~~~">
<location
file="src/main/AndroidManifest.xml"
2022-02-10 19:00:59 +00:00
line="299"
2021-09-11 11:38:13 +00:00
column="10"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_collection_creation.xml"
line="137"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_collection_creation_name_collection.xml"
line="107"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_collection_creation_select_collection.xml"
line="111"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_tracking_protection_panel.xml"
line="15"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_tracking_protection_panel.xml"
2021-09-11 11:38:13 +00:00
line="199"
2021-07-28 18:06:42 +00:00
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_add_on_details.xml"
line="150"
column="10"/>
</issue>
2020-10-05 22:14:02 +00:00
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" < androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
2021-07-28 18:06:42 +00:00
file="src/main/res/layout/fragment_share.xml"
line="30"
column="6"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/library/downloads/DownloadAdapter.kt"
2021-12-06 21:33:33 +00:00
line="43"
2021-09-11 11:38:13 +00:00
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/collections/SaveCollectionListAdapter.kt"
line="50"
column="9"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" tabsTrayBinding.tabsTray.adapter?.notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/tabstray/TabsTrayFragment.kt"
2022-02-10 19:00:59 +00:00
line="384"
2021-09-11 11:38:13 +00:00
column="13"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.library.LibrarySiteItemView"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_recently_closed.xml"
line="12"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < mozilla.components.feature.readerview.view.ReaderViewControlsBar"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_browser.xml"
line="54"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < mozilla.components.feature.prompts.login.LoginSelectBar"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_browser.xml"
line="73"
column="10"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="32"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="41"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="50"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="60"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="70"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.settings.deletebrowsingdata.DeleteBrowsingDataItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_delete_browsing_data.xml"
line="79"
column="14"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.TrackingProtectionCategoryItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_tracking_protection_blocking.xml"
line="36"
column="10"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.TrackingProtectionCategoryItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_tracking_protection_blocking.xml"
line="46"
column="10"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.TrackingProtectionCategoryItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_tracking_protection_blocking.xml"
line="56"
column="10"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.TrackingProtectionCategoryItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_tracking_protection_blocking.xml"
line="66"
column="10"/>
</issue>
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.TrackingProtectionCategoryItem"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_tracking_protection_blocking.xml"
line="76"
column="10"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="MozMultipleConstraintLayoutsAndCustomViews"
message="Custom views extending `ConstraintLayout` are less efficient because they cannot share other `ConstraintLayout` defined in file."
errorLine1=" < org.mozilla.fenix.trackingprotection.SwitchWithDescription"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/quicksettings_tracking_protection.xml"
line="12"
column="6"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="UseCompoundDrawables"
message="This tag and its children can be replaced by one `< TextView/>` and a compound drawable"
errorLine1="< LinearLayout xmlns:android=" http://schemas.android.com/apk/res/android" "
errorLine2=" ~~~~~~~~~~~~">
<location
file="src/main/res/layout/view_synced_tabs_title.xml"
line="5"
column="2"/>
</issue>
2021-12-06 21:33:33 +00:00
<issue
id="LogConditional"
message="The log call Log.i(...) should be conditional: surround with `if (Log.isLoggable(...))` or `if (BuildConfig.DEBUG) { ... }`"
errorLine1=" Log.i(" Crash Reporter" , " Report submitted: $didSubmitReport" )"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/crashes/CrashReporterController.kt"
line="81"
column="9"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/sync_error_background_color` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" @color/sync_error_background_color" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/account_auth_error_preference.xml"
line="13"
column="9"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/white_color` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" @color/white_color" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_migration.xml"
line="9"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/checkbox_left_preference.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/checkbox_left_preference_etp.xml"
line="12"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/checkbox_left_sub_preference.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/component_tracking_protection_panel.xml"
line="13"
column="5"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/connection_details_website_info.xml"
line="13"
column="5"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/custom_search_engine_radio_button.xml"
line="12"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/download_dialog_layout.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?above` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?above" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_crash_reporter.xml"
line="11"
column="5"/>
</issue>
2022-02-10 19:00:59 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?attr/scrimBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?attr/scrimBackground" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_history_search_dialog.xml"
line="13"
column="5"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?homeBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?homeBackground" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_home.xml"
line="16"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?attr/scrimBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?attr/scrimBackground" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_search_dialog.xml"
line="13"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_sign_out.xml"
line="10"
column="5"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="Overdraw"
2021-12-06 21:33:33 +00:00
message="Possible overdraw: Root element paints background `@color/photonLightGrey30` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" @color/photonLightGrey30" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-09-11 11:38:13 +00:00
<location
2021-12-06 21:33:33 +00:00
file="src/main/res/layout/inactive_tabs_auto_close.xml"
2021-09-11 11:38:13 +00:00
line="11"
column="5"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/info_banner.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/layout_add_credit_card.xml"
2021-09-11 11:38:13 +00:00
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?attr/selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/layout_add_login.xml"
line="11"
2021-07-28 18:06:42 +00:00
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/navigation_toolbar.xml"
line="14"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/preference_search_add_engine.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?android:selectableItemBackground" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/search_engine_radio_button.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?foundation` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" ?foundation" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/stub_find_in_page.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `#FF0250BB` with a theme that also paints a background (inferred theme is `@style/NormalTheme`)"
errorLine1=" android:background=" #FF0250BB" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/tracking_protection_learn_more_preference.xml"
line="10"
column="5"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.resource_scheme` appears to be unused"
errorLine1=" < string name=" resource_scheme" >" resource://" < /string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/arrays.xml"
2022-02-10 19:00:59 +00:00
line="36"
2021-07-28 18:06:42 +00:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.chrome_scheme` appears to be unused"
errorLine1=" < string name=" chrome_scheme" >" chrome://< /string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/arrays.xml"
2022-02-10 19:00:59 +00:00
line="37"
2021-07-28 18:06:42 +00:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.string.about_scheme` appears to be unused"
errorLine1=" < string name=" about_scheme" >" about:" < /string>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/arrays.xml"
2022-02-10 19:00:59 +00:00
line="38"
2021-07-28 18:06:42 +00:00
column="13"/>
</issue>
<issue
id="UnusedResources"
message="The resource `R.array.mozac_url_schemes_blocklist` appears to be unused"
errorLine1=" < string-array name=" mozac_url_schemes_blocklist" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/values/arrays.xml"
2022-02-10 19:00:59 +00:00
line="39"
2021-07-28 18:06:42 +00:00
column="19"/>
</issue>
<issue
id="UnusedResources"
2021-10-07 01:35:34 +00:00
message="The resource `R.dimen.mozac_browser_menu_corner_radius` appears to be unused"
errorLine1=" < dimen name=" mozac_browser_menu_corner_radius" >8dp< /dimen>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-10-07 01:35:34 +00:00
file="src/main/res/values/dimens.xml"
line="12"
column="12"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
id="UnusedResources"
2021-10-07 01:35:34 +00:00
message="The resource `R.dimen.mozac_browser_menu2_corner_radius` appears to be unused"
errorLine1=" < dimen name=" mozac_browser_menu2_corner_radius" >8dp< /dimen>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
2021-07-28 18:06:42 +00:00
<location
2021-10-07 01:35:34 +00:00
file="src/main/res/values/dimens.xml"
line="13"
column="12"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
id="UnusedResources"
2021-10-07 01:35:34 +00:00
message="The resource `R.mipmap.ic_launcher_private` appears to be unused"
errorLine1="< adaptive-icon xmlns:android=" http://schemas.android.com/apk/res/android" >"
errorLine2="^">
2021-07-28 18:06:42 +00:00
<location
2021-10-07 01:35:34 +00:00
file="src/main/res/mipmap-anydpi-v26/ic_launcher_private.xml"
line="6"
column="1"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
id="IconXmlAndPng"
2022-02-10 19:00:59 +00:00
message="The following images appear both as density independent `.xml` files and as bitmap files: /Users/oracle/Projects/fenix/app/src/main/res/drawable-hdpi/ic_logo_wordmark_normal.png, /Users/rotbolt/AndroidStudioProjects/fenix/app/src/main/res/drawable-night/ic_logo_wordmark_normal.xml">
2021-07-28 18:06:42 +00:00
<location
file="src/main/res/drawable-xxxhdpi/ic_logo_wordmark_normal.png"/>
<location
file="src/main/res/drawable-xxhdpi/ic_logo_wordmark_normal.png"/>
<location
file="src/main/res/drawable-xhdpi/ic_logo_wordmark_normal.png"/>
<location
file="src/main/res/drawable-night/ic_logo_wordmark_normal.xml"/>
<location
file="src/main/res/drawable-mdpi/ic_logo_wordmark_normal.png"/>
<location
file="src/main/res/drawable-hdpi/ic_logo_wordmark_normal.png"/>
</issue>
<issue
id="ConvertToWebp"
2021-09-11 11:38:13 +00:00
message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
<location
file="src/debug/res/mipmap-xxxhdpi/ic_launcher_round.png"/>
</issue>
<issue
id="ConvertToWebp"
message="One or more images in this project can be converted to the WebP format which typically results in smaller file sizes, even for lossless conversion">
2021-07-28 18:06:42 +00:00
<location
2022-02-10 19:00:59 +00:00
file="src/main/res/drawable-land-xxhdpi/sunrise.jpg"/>
2021-07-28 18:06:42 +00:00
</issue>
<issue
id="IconLocation"
message="Found bitmap drawable `res/drawable/ic_baidu.png` in densityless folder">
<location
file="src/main/res/drawable/ic_baidu.png"/>
</issue>
<issue
id="IconLocation"
message="Found bitmap drawable `res/drawable/ic_jd.png` in densityless folder">
<location
file="src/main/res/drawable/ic_jd.png"/>
</issue>
2022-01-03 17:00:11 +00:00
<issue
id="IconLocation"
message="Found bitmap drawable `res/drawable/ic_meituan.png` in densityless folder">
<location
file="src/main/res/drawable/ic_meituan.png"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="IconLocation"
message="Found bitmap drawable `res/drawable/ic_pdd.png` in densityless folder">
<location
file="src/main/res/drawable/ic_pdd.png"/>
</issue>
2021-12-06 21:33:33 +00:00
<issue
id="IconLocation"
message="Found bitmap drawable `res/drawable/ic_tc.png` in densityless folder">
<location
file="src/main/res/drawable/ic_tc.png"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="IconDensities"
2022-02-10 19:00:59 +00:00
message="Missing the following drawables in `drawable-mdpi`: amethyst.png, cerulean.png, fenix_search_widget.png, sunrise.jpg">
2021-07-28 18:06:42 +00:00
<location
file="src/main/res/drawable-mdpi"/>
</issue>
<issue
id="IconDensities"
2022-02-10 19:00:59 +00:00
message="Missing the following drawables in `drawable-xhdpi`: amethyst.png, cerulean.png, fenix_search_widget.png, sunrise.jpg">
2021-07-28 18:06:42 +00:00
<location
file="src/main/res/drawable-xhdpi"/>
</issue>
<issue
id="IconDensities"
2022-02-10 19:00:59 +00:00
message="Missing the following drawables in `drawable-xxhdpi`: amethyst.png, cerulean.png, fenix_search_widget.png, sunrise.jpg">
2021-07-28 18:06:42 +00:00
<location
file="src/main/res/drawable-xxhdpi"/>
</issue>
<issue
id="SmallSp"
2021-09-11 11:38:13 +00:00
message="Avoid using sizes smaller than `11sp`: `10sp`"
2021-07-28 18:06:42 +00:00
errorLine1=" android:textSize=" 10sp" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/account_share_list_item.xml"
line="39"
column="9"/>
</issue>
<issue
id="SmallSp"
2021-09-11 11:38:13 +00:00
message="Avoid using sizes smaller than `11sp`: `10sp`"
2021-07-28 18:06:42 +00:00
errorLine1=" android:textSize=" 10sp" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/app_share_list_item.xml"
line="37"
column="9"/>
</issue>
2021-09-11 11:38:13 +00:00
<issue
id="ClickableViewAccessibility"
2021-12-06 21:33:33 +00:00
message="Custom view ``AwesomeBarWrapper`` has `setOnTouchListener` called on it but does not override `performClick`"
2021-09-11 11:38:13 +00:00
errorLine1=" binding.awesomeBar.setOnTouchListener { _, _ ->"
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
2022-01-03 17:00:11 +00:00
line="213"
2021-09-11 11:38:13 +00:00
column="9"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" binding.awesomeBar.setOnTouchListener { _, _ ->"
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
2022-01-03 17:00:11 +00:00
line="213"
2021-09-11 11:38:13 +00:00
column="47"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" dialog?.window?.decorView?.setOnTouchListener { _, event ->"
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
2022-01-03 17:00:11 +00:00
line="227"
2021-07-28 18:06:42 +00:00
column="59"/>
</issue>
2021-12-06 21:33:33 +00:00
<issue
id="ClickableViewAccessibility"
message="Custom view ``SearchDialogFragmentConstraintLayout`` has `setOnTouchListener` called on it but does not override `performClick`"
errorLine1=" binding.searchWrapper.setOnTouchListener { _, _ ->"
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
2022-01-03 17:00:11 +00:00
line="253"
2021-12-06 21:33:33 +00:00
column="17"/>
</issue>
<issue
id="ClickableViewAccessibility"
message="`onTouch` lambda should call `View#performClick` when a click is detected"
errorLine1=" binding.searchWrapper.setOnTouchListener { _, _ ->"
errorLine2=" ^">
<location
file="src/main/java/org/mozilla/fenix/search/SearchDialogFragment.kt"
2022-01-03 17:00:11 +00:00
line="253"
2021-12-06 21:33:33 +00:00
column="58"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="ClickableViewAccessibility"
message="Custom view `SwipeGestureLayout` overrides `onTouchEvent` but not `performClick`"
errorLine1=" override fun onTouchEvent(event: MotionEvent?): Boolean {"
errorLine2=" ~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/fenix/browser/SwipeGestureLayout.kt"
line="120"
column="18"/>
</issue>
2021-09-11 11:38:13 +00:00
2020-10-05 22:14:02 +00:00
<issue
2021-07-28 18:06:42 +00:00
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
2020-10-05 22:14:02 +00:00
<location
2021-07-28 18:06:42 +00:00
file="src/main/res/layout/library_site_item.xml"
2021-12-06 21:33:33 +00:00
line="29"
2020-10-05 22:14:02 +00:00
column="10"/>
</issue>
<issue
2021-07-28 18:06:42 +00:00
id="ContentDescription"
message="Missing `contentDescription` attribute on image"
errorLine1=" < ImageView"
errorLine2=" ~~~~~~~~~">
2020-10-05 22:14:02 +00:00
<location
2021-07-28 18:06:42 +00:00
file="src/main/res/layout/sign_in_preference.xml"
line="17"
column="6"/>
2020-10-05 22:14:02 +00:00
</issue>
2022-02-10 19:00:59 +00:00
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=" @dimen/custom_checkbox_alignment_margin" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/checkbox_left_sub_preference.xml"
line="15"
column="5"/>
</issue>
2021-12-06 21:33:33 +00:00
<issue
id="RtlSymmetry"
message="When you define `paddingStart` you should probably also define `paddingEnd` for right-to-left symmetry"
errorLine1=" android:paddingStart=" 16dp" >"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/inactive_header_item.xml"
line="28"
column="9"/>
</issue>
2021-07-28 18:06:42 +00:00
<issue
id="RtlHardcoded"
message="Consider replacing `android:layout_marginLeft` with `android:layout_marginStart=" 10dp" ` to better support right-to-left layouts"
errorLine1=" android:layout_marginLeft=" 10dp" "
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_privacy_content_display.xml"
line="21"
column="21"/>
2020-10-05 22:14:02 +00:00
</issue>
</issues>
