use shared pointer for RouterInfo's addreses list

1 year ago · d0d0cd8445
parent 410d2c2fa9
commit d0d0cd8445
1 changed files with 6 additions and 4 deletions
--- a/daemon/UPnP.cpp
+++ b/daemon/UPnP.cpp
@ -159,8 +159,9 @@ namespace transport

 	void UPnP::PortMapping ()
 	{
-		const auto& a = context.GetRouterInfo().GetAddresses();
-		for (const auto& address : a)
+		auto a = context.GetRouterInfo().GetAddresses();
+		if (!a) return;
+		for (const auto& address : *a)
 		{
 			if (!address->host.is_v6 () && address->port)
 				TryPortMapping (address);
@ -210,8 +211,9 @@ namespace transport

 	void UPnP::CloseMapping ()
 	{
-		const auto& a = context.GetRouterInfo().GetAddresses();
-		for (const auto& address : a)
+		const a = context.GetRouterInfo().GetAddresses();
+		if (!a) return;
+		for (const auto& address : *a)
 		{
 			if (!address->host.is_v6 () && address->port)
 			CloseMapping (address);