From 57852bfb9c8c53bd66334cb6fac34e4ae614739f Mon Sep 17 00:00:00 2001
From: Justin Wang <justinwang46@gmail.com>
Date: Tue, 23 May 2023 17:37:55 +0200
Subject: [PATCH] add missing accessible props for buttons, remove forgotten
 duplicate accessible props

---
 gpt4all-chat/main.qml           | 6 ++++++
 gpt4all-chat/qml/ChatDrawer.qml | 8 --------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/gpt4all-chat/main.qml b/gpt4all-chat/main.qml
index 329c7acb..81e600fe 100644
--- a/gpt4all-chat/main.qml
+++ b/gpt4all-chat/main.qml
@@ -649,6 +649,9 @@ Window {
                                         anchors.fill: parent
                                         source: "qrc:/gpt4all/icons/thumbs_up.svg"
                                     }
+                                    Accessible.role = Accessible.Button
+                                    Accessible.name = qsTr("Thumbs up")
+                                    Accessible.description = qsTr("Updates response and chatModel state for thumbs up")
                                     onClicked: {
                                         if (thumbsUpState && !thumbsDownState)
                                             return
@@ -682,6 +685,9 @@ Window {
                                         anchors.fill: parent
                                         source: "qrc:/gpt4all/icons/thumbs_down.svg"
                                     }
+                                    Accessible.role = Accessible.Button
+                                    Accessible.name = qsTr("Thumbs down")
+                                    Accessible.description = qsTr("Opens thumbs down dialog")
                                     onClicked: {
                                         thumbsDownDialog.open()
                                     }
diff --git a/gpt4all-chat/qml/ChatDrawer.qml b/gpt4all-chat/qml/ChatDrawer.qml
index 93bdada9..ac8ae1ce 100644
--- a/gpt4all-chat/qml/ChatDrawer.qml
+++ b/gpt4all-chat/qml/ChatDrawer.qml
@@ -38,8 +38,6 @@ Drawer {
             anchors.right: parent.right
             font.pixelSize: theme.fontSizeLarger
             text: qsTr("New chat")
-            Accessible.role: Accessible.Button
-            Accessible.name: text
             Accessible.description: qsTr("Use this to launch an external application that will check for updates to the installer")
             onClicked: {
                 LLM.chatListModel.addChat();
@@ -257,8 +255,6 @@ Drawer {
             anchors.bottom: downloadButton.top
             anchors.bottomMargin: 10
             text: qsTr("Updates")
-            Accessible.role: Accessible.Button
-            Accessible.name: text
             Accessible.description: qsTr("Use this to launch an external application that will check for updates to the installer")
             onClicked: {
                 if (!LLM.checkForUpdates())
@@ -273,8 +269,6 @@ Drawer {
             anchors.bottom: aboutButton.top
             anchors.bottomMargin: 10
             text: qsTr("Downloads")
-            Accessible.role: Accessible.Button
-            Accessible.name: text
             Accessible.description: qsTr("Use this to launch a dialog to download new models")
             onClicked: {
                 downloadClicked()
@@ -287,8 +281,6 @@ Drawer {
             anchors.right: parent.right
             anchors.bottom: parent.bottom
             text: qsTr("About")
-            Accessible.role: Accessible.Button
-            Accessible.name: text
             Accessible.description: qsTr("Use this to launch a dialog to show the about page")
             onClicked: {
                 aboutClicked()