From 11823022e2e3bf4543d0eeab1a2b45c1c824fe3e Mon Sep 17 00:00:00 2001 From: Adam Treat Date: Wed, 26 Jun 2024 14:53:44 -0400 Subject: [PATCH] Add a fixme for combobox popups in general which is less than ideal right now. Signed-off-by: Adam Treat --- gpt4all-chat/qml/MyComboBox.qml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gpt4all-chat/qml/MyComboBox.qml b/gpt4all-chat/qml/MyComboBox.qml index f61bc017..eca28256 100644 --- a/gpt4all-chat/qml/MyComboBox.qml +++ b/gpt4all-chat/qml/MyComboBox.qml @@ -33,6 +33,9 @@ ComboBox { highlighted: comboBox.highlightedIndex === index } popup: Popup { + // FIXME This should be made much nicer to take into account lists that are very long so + // that it is scrollable and also sized optimally taking into account the x,y and the content + // width and height as well as the window width and height y: comboBox.height - 1 width: comboBox.width implicitHeight: contentItem.implicitHeight