Commit Graph

96 Commits (fe2232305dc933add274a3ebe7cdcd438f476f3a)

Author SHA1 Message Date
Josh Rabinowitz 68b64f4aac
make correction to comments (#525) 5 years ago
Josh Rabinowitz 9ff559ca8c
Issue 478 tests in busybox (#523)
* use busybox by not installing coreutils on alpine
* changes for busybox version of ps and stat
* add function to check if exe is from busybox
* update changelog
* cleanup comments, code, and commented out code
* improve comment in alpine Dockerfile
* include platform-specific funcs so we can test perms
5 years ago
Josh Rabinowitz baf6c4113b
Add SECRETS_PINENTRY env var and docs (#490)
* Add SECRETS_PINENTRY env var 

* add docs and tests for SECRETS_PINENTRY

* improve diagnostic output

* fix regex example for bats-core diagnostics
5 years ago
Josh Rabinowitz 10fa2a7be2
Tempfile and temp directory cleanups (#473)
* Tempfile and temp directory cleanups
    Add comments about mktemp on different platforms
    Be more careful about tempfile cleanups
    Don't use find to locate files to cleanup
    Use shorter SECRETS_EXTENSION and SECRETS_DIR env settings in tests
    Set TMPDIR in tests again
    Show DESTDIR used when testing git-secret install
    Change filename passed to mktemp -t in tests
5 years ago
Simon Massey 10879e2253
fix for git secret hide -m doesn't work on first use #466 (#469) 5 years ago
Josh Rabinowitz 44a8745e02
remove duplicate test (#458) 5 years ago
Josh Rabinowitz bbb4d9d3e5
Tmp cleanups (#457)
* Only show 'cleaning up temp file' messages if one
  of SECRETS_VERBOSE or SECRETS_TEST_VERBOSE is set.
* Adjust tests to reflect the change.
* Add note about suppressing 'cleaning up' msgs to CHANGELOG.md and reorder entries
* add comments showing examples of tmpfiles returned
5 years ago
Josh Rabinowitz 24bfc86b74
Fail on extra params (#448)
* fail if user passes unexpected filenames or unknown params
* mention fix of #390
5 years ago
Josh Rabinowitz 2341d1433b
Temp dir fixes (#449)
* perform our test install into TMPDIR
* fix typo
* remove duplicate entry in CHANGELOG.md
* improve commenting
5 years ago
Josh Rabinowitz cb1636a6dc
experimental SECRETS_TEST_VERBOSE shows debug info during tests (#446)
* add a travis target using SECRETS_TEST_VERBOSE=1
* Document SECRETS_TEST_VERBOSE as experimental
* note experimental feature may change or be removed
5 years ago
Josh Rabinowitz 8334d7beef
Reveal verbose (#447)
* add -v option to reveal, for #395
* update reveal man page
* shellcheck exception
* changelog update for 'reveal -v'
5 years ago
Josh Rabinowitz 07af0c19b6
Varnames output and typos (#441)
* rename variable, fix typo, improve comments and output
* fix directory removal after testing
* mention improved user messaging in CHANGELOG.md
5 years ago
Josh Rabinowitz be88da4c0c
test 'DESTDIR=/dir/here make install' support (#438) 5 years ago
Josh Rabinowitz ce8c6b3ae0
Change 'add' to add to .gitignore by default. (#429)
* Change 'add' to add to .gitignore by default.
Also add _message() function and improve output from 'git-secret-add',
alter tests for new code behavior, and update docs.
* change tests since 'add' always adds to .gitignore
* improve output: prepend more message with 'git-secret:'.
* update man page for git-secret-add
5 years ago
Jonas Karlsson 54f74ede6a Fix for windows (#375)
* add test for travis-ci windows support
* Make 'ps' command options platform specific *nix/windows
* Add _clean_path for windows,  apply to all homedir input arguments
* export GITSECRET_DIST="windows" in git hook if running windows
* Bash lint fixes
5 years ago
Josh Rabinowitz 8adb7d5741
Revert "use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)" (#405)
This reverts commit a2a9bd32ba.
5 years ago
Josh Rabinowitz a2a9bd32ba
use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)
* use pgrep & kill, not ps+gawk+regex+system+kill
* install shellcheck and enable lint on macos/brew.
* add shellcheck fixes and exception
* reorder CHANGELOG entries
5 years ago
Josh Rabinowitz 22fe1ed2d4
Add support for SECRETS_VERBOSE env var (#393)
* Support SECRETS_VERBOSE env var in addition to -v
* don't use --quiet when decrypting in verbose mode
* show output of gpg encryption in verbose mode
* add tests for SECRETS_VERBOSE env var set to 0 and 1
* update changelog, reorder entries.
* add tests for 'cat' and 'hide' with SECRETS_VERBOSE=1
5 years ago
Josh Rabinowitz c4331693f3
use 'kill', not 'kill -9' (#379) 5 years ago
Josh Rabinowitz 7b06b25c0a
Respect secrets dir on init, and document (#366)
* respect SECRETS_DIR and SECRETS_EXTENSION in tests
* add line regarding fixes to CHANGELOG.md
* test with non-standard SECRETS_EXTENSION
* Add details about init, mention SECRETS_EXTENSION in init page
* update git-secret-init man page
5 years ago
Josh Rabinowitz 505cb1fe42 have lint target run shellcheck over tests (closes #373)
* have lint target run shellcheck over tests

* lint and fix tests/ since shellcheck knows bats

* lint and fix tests/ since shellcheck knows bats

* revert debug output

* changes for shellcheck

* revert unintended change

  [tests/_test_base.bash]

* use 'local' for user/filename vars, not 'export'

* add note about Shellcheck and tests/

* local can only be used in functions - use export

* restore shbang edited in error
5 years ago
Josh Rabinowitz 83b03b61bc
Aspell fixes (#365)
* spellcheck fixes from aspell
5 years ago
Josh Rabinowitz 8ed4f46de6
fix test under git hook (#349)
* fix test under git hook. Actually closes #334
5 years ago
Josh Rabinowitz 5a28744c5d
Fix for tests under bats, fix typos, mention #334 (#342)
* fix test under githooks, fix typos, mention #334 as relevant
5 years ago
Josh Rabinowitz e34248fdc1
remove diagnostic output from tests (#329) 6 years ago
Josh Rabinowitz 65fe4c4127
Add verbose option to 'git secret tell' showing output of key imports (#321)
* add 'git secret tell -v' option to show output of key imports
* add tests for tell with/without -v
* remove unneeded test code and bats diagnostic output
6 years ago
Josh Rabinowitz 913d026537
Fixes for 'changes' and trailing newlines, for #291 (#293)
* tests and comments about 'changes' for #291
* add 'changes' tests, improve diagnostic 
* preserve trailing newlines in diff output
* use bash trickery to preserve trailing newlines in captured text
* test 'changes' on files without newlines and when called on a non-existant file
* improve comments and variable names
6 years ago
Josh Rabinowitz 9cccf162c6 WIP: test with expired key, add 'whoknows -l' (#287)
* test with expired key, add 'whoknows -l'

    * 'whoknows -l' shows key expiration dates
    * also added docs and tests for `whoknows -l`,
    * tests for expired keys,
    * epoch_to_date functions

* update man pages

* fix epoch-to-date conversion on OSX

* test output of 'whoknows -l'

* fix for lint/shellcheck

* fix for osx

* lint fix

* use date as found in $PATH

* disable 'set -e' as little as possible
6 years ago
Josh Rabinowitz 74f8a07166
improve testing regarding expired keys and keys with only email addresses (#262)
* test that hiding secret with expired key fails
* add test of user key without username.
* revert to performing most tests with 'user1'.
* move user4 private/public key fixtures
* factor code fetching emails from keyrings, add comments.
* use factored _warn_or_abort()
* add to, clean up, and clarify comments.
6 years ago
Josh Rabinowitz 4a3877b486
WIP: Force mode for hide and reveal (#263)
* -F (force even if gpg fails) option for hide and reveal
* allow 'reveal' to decrypt a subset of files.
* update and regen man pages
* man pages update and improvements
* text about why all files should be hidden at once
* add _warn() and _warn_or_abort()
* tests for -F option
* glob source .sh files in Makefile better
* add comment about issue #238. cleanup error msg.
* test exact case in #253
* disable gnupg doc building on ubuntu-rolling
6 years ago
Josh Rabinowitz 9e975e4eed make sure email addresses used with 'tell' and 'killperson' exist in keyring (#267)
* name keys after emails, not usernames

* use emails to specify users

* rename and add function to get emails from keyrings
* rename directories holding gpg test fixtures

* deny emails that aren't in the keyring, and test.

* require 'killperson' emails to exist in keyring

* change test to reflect killperson must use email

* remove no-longer-needed test function

* factor function _assert_keychain_contains_emais()

* fix/make lint happy
6 years ago
joshr 4c2c9a9719 remove diagnostic debug output 6 years ago
joshr 6eedaab489 rename test to show SECRETS_DIR. add debug output. 6 years ago
joshr 2287b3e54e test that $_SECRETS_DIR is set as expected 6 years ago
joshr 4dd04a06e0 comment out old debug code 6 years ago
joshr 1ea3b3139d clarify comment for devs regarding bats TAP diagnostic output 6 years ago
joshr 5d5392232b remove debug code 6 years ago
joshr 645fc2370e change preserve option from -C to -P 6 years ago
joshr afec23fb17 add test for -C option. fix typos in comments. 6 years ago
joshr 835fe80d8f set permissions when hiding files. change option to -C. 6 years ago
joshr a090bbddac fix 6 years ago
joshr cfdca85469 fixes, use _get_encrypted_filename, show TAP diag output 6 years ago
joshr eb528df301 test permissions 6 years ago
joshr 2e7d6a12a5 add -c (preserve permission) option to reveal. For #172 6 years ago
Josh Rabinowitz 246825c658
fix for keys with only emails, and no usernames. Closes #227 (#240)
* test and fix for keys with only emails, and no usernames. Closes #227
6 years ago
joshr c141fd4492 test with filenames with spaces 6 years ago
joshr 7096499465 fix quoting for files with spaces. use filenames from _test_base.bats 6 years ago
joshr 7648e2f604 cleanup 6 years ago
joshr 2b28271d8b create a test displaying issue #230 6 years ago
Josh Rabinowitz 5d97c66e90 for testing, use bats-core v1.0.2, not bats 6 years ago