Commit Graph

127 Commits (master)

Author SHA1 Message Date
Ochan Kwon b0378617e2
bug fix for 'reveal' in a subdir (#903) (#905) 2 years ago
Josh Rabinowitz 77c0b27006
have hide -v show output from gnupg (#888)
* also document bug #834 and improve comments
2 years ago
Josh Rabinowitz 549cd9aa24
Issue 706 decrypt errors (#831)
* check for encrypted version of file before decrypting, for #706
* improve error messages, verbose output and non-verbose output
* in tests, prefix output from git init with 'git: '
* 'clean' options only remove added files, for #833
* update changelog
2 years ago
Josh Rabinowitz 120edded4f
Cleanups 2022 04 (#824)
* change file desc we use to pass gnupg info
* improve content and phrasing in docs
* improve docs about locations of private/public keys
* update changelog
2 years ago
Nikita Sobolev a97dd7ffa8
`SECRETS_TEST_VERBOSE` can be `0` (#816)
* `SECRETS_TEST_VERBOSE` can be `0`

* Update _git_secret_tools.sh
2 years ago
Josh Rabinowitz db03c638d5
in verbose mode, show some gnupg perm warnings (#812)
* set git-secret keys dir to 700 perms, for #811
* update changelog
* test improvements
* clean up comments
* remove unused code
* update git-secret-init man page
* document change to git-secret-init
2 years ago
Josh Rabinowitz 563ae4ec82
improve testing gitignore, add verbose test on osx (#800)
* Improve testing of .gitignore contents
* add an automated verbose output test on osx
* rename variables, comment improvements
2 years ago
Josh Rabinowitz eefa10623a
changes to .gitignore usage and testing in response to #789 (#791)
* test .gitignore has expected line count, for #792
* let 'add' append filenames to .gitignore in tests
* add comments related to #789
* fix test to allow for more output from 'add'
* improve error message output
* allow for extra output from 'add' in test
* tweaks as per shellcheck lint
* improve comments, cleanup code
* update changelog
* describe test better
2 years ago
Josh Rabinowitz 50734fd364
cleanups and renames (#784)
* rename _append_* functions to _prepend_*
* improve code flow
* be more standard with shellcheck disables
2 years ago
Josh Rabinowitz ba1dc04f3d
show and fix 'style' complaints from shellcheck (#779) 2 years ago
joshr 5bce23ac87 move test to correct test file 2 years ago
Josh Rabinowitz bf45916088
add test by Emily-RoseSteyn, for #636 (#757) 2 years ago
Josh Rabinowitz 84d1f85c56
fix for #710, using cat from a subdir (#751)
* fix for #710, using cat from a subdir
* also fix using reveal with named files from a subdir
2 years ago
Josh Rabinowitz 23acae1265
Issue 630 hide armored2 (#661)
* use gpg --armor when hiding/encrypting files

* update changelog

* Adds SECRETS_GPG_ARMOR env variable

* Fixes lint

* One more test

* Addresses review

Co-authored-by: sobolevn <mail@sobolevn.me>
3 years ago
Pedro Sobota ac3b77a5bc
Newline not added to .gitignore entry on add (#645)
* Fix Newline not added to .gitignore entry on add (#643)
* Updates to CHANGELOG.md
* Add tests
3 years ago
Jeppe Fihl-Pearson fae00fac3d
Rename `killperson` to `removeperson` (#685)
* Rename the "killperson" command to "removeperson"

"killperson" is unnecessarily hostile so change the command name to
"removeperson".

Fixes #684.

* Re-generate man pages

* Update contribution guide

There's no longer any pre-commit hooks so don't mention them.

* Add alias from `killperson` pointing at `removeperson`

* Update git_secret_removeperson.sh

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
3 years ago
Nikita Sobolev 19941f91f4
Adds release-ci script to test installation (#664)
* Adds release-ci script to test installation

* Fixes CI

* Fixes CI

* Renames some variables to follow the same SECRETS_ convention
3 years ago
sobolevn 5fc8ecbdde Adds hadolint, re-enables shellcheck 3 years ago
sobolevn 28dbdf3fde Adds fedora testing 3 years ago
sobolevn 22d994c372 Adds alpine tests 3 years ago
sobolevn 8f7b9c51de [WIP] New CI 3 years ago
Josh Rabinowitz ee592b8ede
Issue 634 tell duplicate emails (#637)
* support asserting named keyring is missing email(s)
* improve error if git-secret keyring missing email
* new test for telling same email twice
* update tell manpage regarding duplicate emails
* regenerate man pages
* update changelog
3 years ago
Sasha Friedenberg 39ab72f866
add bash string escaping to _add_ignored_file (#626) 4 years ago
Bertjan Broeksema fc51d6f15f
More precise feedback about added files (#614)
* More precise feedback about added files

This adapts the output of the add command in order to report exactly
how many files have been added. Specially with wildcard patterns, this
makes it easier to verify that expected files are added.

With the verbose option, the add command will also tell which files
have been added.

By @bbroeksema bbroeksema
4 years ago
Josh Rabinowitz bdc3560897
Issue 607 fix expired test key (#608)
* updated fixture key for user3, fixes #607
* update tests/fixtures/gpg/README.md
* mention fix of #607 and #609 in changelog
* use shellcheck 0.7.1, not 'latest' for #609
4 years ago
Josh Rabinowitz a0a176fa5d
Issue 552 508 revoked keys (#553)
* warn about 'tell' on expired/revoked/invalid keys
* error if 'tell' used on email with multiple keys
* improve test of 'tell' with subdirs
4 years ago
Josh Rabinowitz 2830ce2ff7
Issue 579 reveal clobbers (#580)
* Don't let reveal clobber secret files, for #579
4 years ago
Josh Rabinowitz 9348cd32e2
Revert "Issue 554 show gpg commands (#556)" (#559)
This reverts commit 9e8438236c.
5 years ago
Josh Rabinowitz 9e8438236c
Issue 554 show gpg commands (#556)
* show most gpg commands used for 'hide', 'reveal', 'tell' and 'killperson (#554)
* fix hang when using ctrl-c during tests (#558)
5 years ago
Josh Rabinowitz 2a1600f2f6
cleanup output when we clean up tmp files (#532)
* cleanup output when we clean up tmp files
5 years ago
Josh Rabinowitz 525305d985
Issue 527 key with comment (#528)
* add key fixture with no email, and 2 word comment
* tests for key without email and with comment
* handle comments in public key uids
* fix tests, you have to use email address
* fix text
* confirm that email addresses contain an @ symbol
* improve comments about keys/fixtures
5 years ago
Josh Rabinowitz 68b64f4aac
make correction to comments (#525) 5 years ago
Josh Rabinowitz 9ff559ca8c
Issue 478 tests in busybox (#523)
* use busybox by not installing coreutils on alpine
* changes for busybox version of ps and stat
* add function to check if exe is from busybox
* update changelog
* cleanup comments, code, and commented out code
* improve comment in alpine Dockerfile
* include platform-specific funcs so we can test perms
5 years ago
Josh Rabinowitz baf6c4113b
Add SECRETS_PINENTRY env var and docs (#490)
* Add SECRETS_PINENTRY env var 

* add docs and tests for SECRETS_PINENTRY

* improve diagnostic output

* fix regex example for bats-core diagnostics
5 years ago
Josh Rabinowitz 10fa2a7be2
Tempfile and temp directory cleanups (#473)
* Tempfile and temp directory cleanups
    Add comments about mktemp on different platforms
    Be more careful about tempfile cleanups
    Don't use find to locate files to cleanup
    Use shorter SECRETS_EXTENSION and SECRETS_DIR env settings in tests
    Set TMPDIR in tests again
    Show DESTDIR used when testing git-secret install
    Change filename passed to mktemp -t in tests
5 years ago
Simon Massey 10879e2253
fix for git secret hide -m doesn't work on first use #466 (#469) 5 years ago
Josh Rabinowitz 44a8745e02
remove duplicate test (#458) 5 years ago
Josh Rabinowitz bbb4d9d3e5
Tmp cleanups (#457)
* Only show 'cleaning up temp file' messages if one
  of SECRETS_VERBOSE or SECRETS_TEST_VERBOSE is set.
* Adjust tests to reflect the change.
* Add note about suppressing 'cleaning up' msgs to CHANGELOG.md and reorder entries
* add comments showing examples of tmpfiles returned
5 years ago
Josh Rabinowitz 24bfc86b74
Fail on extra params (#448)
* fail if user passes unexpected filenames or unknown params
* mention fix of #390
5 years ago
Josh Rabinowitz 2341d1433b
Temp dir fixes (#449)
* perform our test install into TMPDIR
* fix typo
* remove duplicate entry in CHANGELOG.md
* improve commenting
5 years ago
Josh Rabinowitz cb1636a6dc
experimental SECRETS_TEST_VERBOSE shows debug info during tests (#446)
* add a travis target using SECRETS_TEST_VERBOSE=1
* Document SECRETS_TEST_VERBOSE as experimental
* note experimental feature may change or be removed
5 years ago
Josh Rabinowitz 8334d7beef
Reveal verbose (#447)
* add -v option to reveal, for #395
* update reveal man page
* shellcheck exception
* changelog update for 'reveal -v'
5 years ago
Josh Rabinowitz 07af0c19b6
Varnames output and typos (#441)
* rename variable, fix typo, improve comments and output
* fix directory removal after testing
* mention improved user messaging in CHANGELOG.md
5 years ago
Josh Rabinowitz be88da4c0c
test 'DESTDIR=/dir/here make install' support (#438) 5 years ago
Josh Rabinowitz ce8c6b3ae0
Change 'add' to add to .gitignore by default. (#429)
* Change 'add' to add to .gitignore by default.
Also add _message() function and improve output from 'git-secret-add',
alter tests for new code behavior, and update docs.
* change tests since 'add' always adds to .gitignore
* improve output: prepend more message with 'git-secret:'.
* update man page for git-secret-add
5 years ago
Jonas Karlsson 54f74ede6a Fix for windows (#375)
* add test for travis-ci windows support
* Make 'ps' command options platform specific *nix/windows
* Add _clean_path for windows,  apply to all homedir input arguments
* export GITSECRET_DIST="windows" in git hook if running windows
* Bash lint fixes
5 years ago
Josh Rabinowitz 8adb7d5741
Revert "use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)" (#405)
This reverts commit a2a9bd32ba.
5 years ago
Josh Rabinowitz a2a9bd32ba
use pgrep & kill $pid, not ps+gawk+regex+system+kill (#400)
* use pgrep & kill, not ps+gawk+regex+system+kill
* install shellcheck and enable lint on macos/brew.
* add shellcheck fixes and exception
* reorder CHANGELOG entries
5 years ago
Josh Rabinowitz 22fe1ed2d4
Add support for SECRETS_VERBOSE env var (#393)
* Support SECRETS_VERBOSE env var in addition to -v
* don't use --quiet when decrypting in verbose mode
* show output of gpg encryption in verbose mode
* add tests for SECRETS_VERBOSE env var set to 0 and 1
* update changelog, reorder entries.
* add tests for 'cat' and 'hide' with SECRETS_VERBOSE=1
5 years ago
Josh Rabinowitz c4331693f3
use 'kill', not 'kill -9' (#379) 5 years ago