Handle invalid flags better: SC2220

src/_utils/_git_secret_tools.sh

@@ -277,8 +277,10 @@ function _show_manual_for {
 
 # Invalid options
 
-function _invalid_option {
-  echo "Invalid option."
+function _invalid_option_for {
+  local function_name="$1" # required
+
+  man "git-secret-${function_name}"
   exit 1
 }
 

src/commands/git_secret_add.sh

@@ -11,7 +11,7 @@ function add {
 
       h) _show_manual_for "add";;
 
-      *) _invalid_option;;
+      *) _invalid_option_for "add";;
     esac
   done
 

src/commands/git_secret_changes.sh

@@ -13,7 +13,7 @@ function changes {
 
       d) homedir=$OPTARG;;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'changes';;
     esac
   done
 

src/commands/git_secret_clean.sh

@@ -12,7 +12,7 @@ function clean {
 
       h) _show_manual_for 'clean';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'clean';;
     esac
   done
 

src/commands/git_secret_hide.sh

@@ -98,7 +98,7 @@ function hide {
 
       h) _show_manual_for 'hide';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'hide';;
     esac
   done
 

src/commands/git_secret_init.sh

@@ -46,7 +46,7 @@ function init {
     case "$opt" in
       h) _show_manual_for 'init';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'init';;
     esac
   done
 

src/commands/git_secret_killperson.sh

@@ -8,7 +8,7 @@ function killperson {
     case "$opt" in
       h) _show_manual_for 'killperson';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'killperson';;
     esac
   done
 

src/commands/git_secret_list.sh

@@ -8,7 +8,7 @@ function list {
     case "$opt" in
       h) _show_manual_for 'list';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'list';;
     esac
   done
 

src/commands/git_secret_remove.sh

@@ -12,7 +12,7 @@ function remove {
 
       h) _show_manual_for 'remove';;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'remove';;
     esac
   done
 

src/commands/git_secret_reveal.sh

@@ -18,7 +18,7 @@ function reveal {
 
       d) homedir=$OPTARG;;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'reveal';;
     esac
   done
 

src/commands/git_secret_tell.sh

@@ -30,7 +30,7 @@ function tell {
 
       d) homedir=$OPTARG;;
 
-      *) _invalid_option;;
+      *) _invalid_option_for 'tell';;
     esac
   done
 

src/commands/git_secret_usage.sh

@@ -8,7 +8,7 @@ function usage {
     case "$opt" in
       h) _show_manual_for "usage";;
 
-      *) _invalid_option;;
+      *) _invalid_option_for "usage";;
     esac
   done
 

src/commands/git_secret_whoknows.sh

@@ -8,7 +8,7 @@ function whoknows {
     case "$opt" in
       h) _show_manual_for "whoknows";;
 
-      *) _invalid_option;;
+      *) _invalid_option_for "whoknows";;
     esac
   done