From 6725151a994da0493aa2925c7fc141c1618bc3f9 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sat, 15 Jul 2017 16:58:21 +0900 Subject: [PATCH] Remove unnecessary copy of Chunk slice --- src/chunklist.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/chunklist.go b/src/chunklist.go index 1144274c..f6bedcc5 100644 --- a/src/chunklist.go +++ b/src/chunklist.go @@ -79,15 +79,8 @@ func (cl *ChunkList) Snapshot() ([]*Chunk, int) { // Duplicate the last chunk if cnt := len(ret); cnt > 0 { - ret[cnt-1] = ret[cnt-1].dupe() + newChunk := *ret[cnt-1] + ret[cnt-1] = &newChunk } return ret, cl.count } - -func (c *Chunk) dupe() *Chunk { - newChunk := make(Chunk, len(*c)) - for idx, ptr := range *c { - newChunk[idx] = ptr - } - return &newChunk -}