Merge pull request #6 from fisherdarling/update-to-2018

Updated to 2018 edition. Refactored some sections.

Cargo.toml

@@ -8,12 +8,12 @@ version = "0.1.2"
 authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
 license = "MIT"
 repository = "https://github.com/sgeisler/cargo-remote"
+edition = "2018"
 
 [dependencies]
-structopt = "0.1.6"
-structopt-derive = "0.1.6"
-cargo_metadata = "0.4.1"
+structopt = "0.2.18"
+cargo_metadata = "0.8.0"
 log = "0.4.1"
-simple_logger = "0.4.0"
-toml = "0.4.5"
+simple_logger = "1.3.0"
+toml = "0.5.1"
 xdg = "2.1.0"

src/main.rs

@@ -1,31 +1,13 @@
-extern crate structopt;
-#[macro_use]
-extern crate structopt_derive;
-
-extern crate cargo_metadata;
-
-#[macro_use] extern crate log;
-extern crate simple_logger;
-
-extern crate toml;
-
-extern crate xdg;
-
-use std::process::{exit, Command, Stdio};
 use std::path::{Path, PathBuf};
-use std::fs::File;
-use std::io::Read;
-use std::borrow::Borrow;
+use std::process::{exit, Command, Stdio};
 
 use structopt::StructOpt;
-
 use toml::Value;
 
+use log::{error, info, warn};
+
 #[derive(StructOpt, Debug)]
-#[structopt(
-    name = "cargo-remote",
-    bin_name = "cargo",
-)]
+#[structopt(name = "cargo-remote", bin_name = "cargo")]
 enum Opts {
     #[structopt(name = "remote")]
     Remote {
@@ -42,9 +24,10 @@ enum Opts {
         #[structopt(
             long = "manifest-path",
             help = "Path to the manifest to execute",
+            default_value = "Cargo.toml",
             parse(from_os_str)
         )]
-        manifest_path: Option<PathBuf>,
+        manifest_path: PathBuf,
 
         #[structopt(
             short = "h",
@@ -61,98 +44,104 @@ enum Opts {
             name = "remote options"
         )]
         options: Vec<String>,
-    }
+    },
 }
 
 /// Tries to parse the file [`config_path`]. Logs warnings and returns [`None`] if errors occur
 /// during reading or parsing, [`Some(Value)`] otherwise.
 fn config_from_file(config_path: &Path) -> Option<Value> {
-    File::open(config_path).ok().and_then(|mut file| {
-        let mut config_file_string = "".to_owned();
-        file.read_to_string(&mut config_file_string).or_else(|e| {
-            warn!("Can't read config file '{}' (error: {})", config_path.to_string_lossy(), e);
-            Err(e)
-        }).ok()?;
-        config_file_string.parse::<Value>().or_else(|e| {
-            warn!("Can't parse config file '{}' (error: {})", config_path.to_string_lossy(), e);
-            Err(e)
-        }).ok()
-    })
+    let config_file = std::fs::read_to_string(config_path)
+        .map_err(|e| {
+            warn!(
+                "Can't parse config file '{}' (error: {})",
+                config_path.to_string_lossy(),
+                e
+            );
+        })
+        .ok()?;
+
+    let value = config_file
+        .parse::<Value>()
+        .map_err(|e| {
+            warn!(
+                "Can't parse config file '{}' (error: {})",
+                config_path.to_string_lossy(),
+                e
+            );
+        })
+        .ok()?;
+
+    Some(value)
 }
 
 fn main() {
     simple_logger::init().unwrap();
 
-    let Opts::Remote{
+    let Opts::Remote {
         remote,
         copy_back,
         manifest_path,
         hidden,
         command,
-        options
+        options,
     } = Opts::from_args();
 
-    let manifest_path = manifest_path.as_ref().map(PathBuf::borrow);
-    let project_metadata = cargo_metadata::metadata(manifest_path)
-        .unwrap_or_else(|e| {
-            error!("Could not read cargo metadata: {}", e);
-            exit(-1);
-        });
+    let mut metadata_cmd = cargo_metadata::MetadataCommand::new();
+    metadata_cmd.manifest_path(manifest_path).no_deps();
+
+    let project_metadata = metadata_cmd.exec().unwrap();
 
     // for now, assume that there is only one project and find it's root directory
-    let (project_dir, project_name) = project_metadata.packages.first().map_or_else(|| {
-        error!("No project found.");
-        exit(-2);
-    }, |project| {
-        (
-            Path::new(&project.manifest_path)
-                .parent()
-                .expect("Cargo.toml seems to have no parent directory?"),
-            &project.name
-        )
-    });
+    let (project_dir, project_name) = project_metadata.packages.first().map_or_else(
+        || {
+            error!("No project found.");
+            exit(-2);
+        },
+        |project| (&project_metadata.workspace_root, &project.name),
+    );
 
     let configs = vec![
         config_from_file(&project_dir.join(".cargo-remote.toml")),
         xdg::BaseDirectories::with_prefix("cargo-remote")
             .ok()
             .and_then(|base| base.find_config_file("cargo-remote.toml"))
-            .and_then(|p: PathBuf| config_from_file(&p)
-        ),
+            .and_then(|p: PathBuf| config_from_file(&p)),
     ];
 
     // TODO: move Opts::Remote fields into own type and implement complete_from_config(&mut self, config: &Value)
-    let build_server = remote.or_else(|| {
-        configs.into_iter()
-            .flat_map(|config| {
-                config.and_then(|c| {
-                    c["remote"].as_str().map(str::to_owned)
-                })
-            })
-            .next()
-    }).unwrap_or_else(|| {
-        error!("No remote build server was defined (use config file or --remote flag)");
-        exit(-3);
-    });
+    let build_server = remote
+        .or_else(|| {
+            configs
+                .into_iter()
+                .flat_map(|config| config.and_then(|c| c["remote"].as_str().map(String::from)))
+                .next()
+        })
+        .unwrap_or_else(|| {
+            error!("No remote build server was defined (use config file or --remote flag)");
+            exit(-3);
+        });
+
+    let build_path = format!("~/remote-builds/{}/", project_name);
 
     info!("Transferring sources to build server.");
     // transfer project to build server
     let mut rsync_to = Command::new("rsync");
-    rsync_to.arg("-a".to_owned())
+    rsync_to
+        .arg("-a".to_owned())
         .arg("--delete")
         .arg("--info=progress2")
         .arg("--exclude")
         .arg("target");
 
     if !hidden {
-        rsync_to.arg("--exclude")
-            .arg(".*");
+        rsync_to.arg("--exclude").arg(".*");
     }
 
-    rsync_to.arg("--rsync-path")
+    rsync_to
+        .arg("--rsync-path")
         .arg("mkdir -p remote-builds && rsync")
         .arg(format!("{}/", project_dir.to_string_lossy()))
-        .arg(format!("{}:~/remote-builds/{}/", build_server, project_name))
+        .arg(format!("{}:{}", build_server, build_path))
         .stdout(Stdio::inherit())
         .stderr(Stdio::inherit())
         .stdin(Stdio::inherit())
@@ -163,17 +152,15 @@ fn main() {
         });
 
     let build_command = format!(
-        "cd ~/remote-builds/{}/; $HOME/.cargo/bin/cargo {} {}",
-        project_name,
+        "cd {}; $HOME/.cargo/bin/cargo {} {}",
+        build_path,
         command,
-        options.iter().fold(
-            String::new(),
-            |acc, x| format!("{} {}", acc, x)
-        )
+        options.join(" ")
     );
 
     info!("Starting build process.");
     Command::new("ssh")
+        .arg("-t")
         .arg(&build_server)
         .arg(build_command)
         .stdout(Stdio::inherit())
@@ -192,14 +179,17 @@ fn main() {
             .arg("--delete")
             .arg("--compress")
             .arg("--info=progress2")
-            .arg(format!("{}:~/remote-builds/{}/target/", build_server, project_name))
+            .arg(format!("{}:{}/target/", build_server, build_path))
             .arg(format!("{}/target/", project_dir.to_string_lossy()))
             .stdout(Stdio::inherit())
             .stderr(Stdio::inherit())
             .stdin(Stdio::inherit())
             .output()
             .unwrap_or_else(|e| {
-                error!("Failed to transfer target back to local machine (error: {})", e);
+                error!(
+                    "Failed to transfer target back to local machine (error: {})",
+                    e
+                );
                 exit(-6);
             });
     }