From 5162e2eed76eac9a128cc2ddeb19eb4336cb339b Mon Sep 17 00:00:00 2001
From: Jonathan Rehm <jonathan@rehm.me>
Date: Fri, 28 Jul 2017 20:01:31 -0700
Subject: [PATCH 1/5] Add img alt attributes

---
 cps/templates/detail.html   | 4 ++--
 cps/templates/discover.html | 2 +-
 cps/templates/index.html    | 8 ++++----
 cps/templates/search.html   | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/cps/templates/detail.html b/cps/templates/detail.html
index 882b2ba2..2859d64c 100644
--- a/cps/templates/detail.html
+++ b/cps/templates/detail.html
@@ -5,9 +5,9 @@
     <div class="col-sm-3 col-lg-3 col-xs-5">
       <div class="cover">
         {% if entry.has_cover %}
-          <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" />
+          <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" alt="{{ entry.title }}" />
         {% else %}
-          <img src="{{ url_for('static', filename='generic_cover.jpg') }}" />
+          <img src="{{ url_for('static', filename='generic_cover.jpg') }}" alt="{{ entry.title }}" />
         {% endif %}
       </div>
     </div>
diff --git a/cps/templates/discover.html b/cps/templates/discover.html
index ff79c23b..53d73168 100644
--- a/cps/templates/discover.html
+++ b/cps/templates/discover.html
@@ -9,7 +9,7 @@
       <div class="cover">
         {% if entry.has_cover is defined %}
           <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
-            <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" />
+            <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" alt="{{ entry.title }}" />
           </a>
         {% endif %}
       </div>
diff --git a/cps/templates/index.html b/cps/templates/index.html
index 72df252a..c5d156ce 100755
--- a/cps/templates/index.html
+++ b/cps/templates/index.html
@@ -10,9 +10,9 @@
       <div class="cover">
           <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
             {% if entry.has_cover %}
-              <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" />
+              <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" alt="{{ entry.title }}" />
             {% else %}
-              <img src="{{ url_for('static', filename='generic_cover.jpg') }}" />
+              <img src="{{ url_for('static', filename='generic_cover.jpg') }}" alt="{{ entry.title }}" />
             {% endif %}
           </a>
       </div>
@@ -46,9 +46,9 @@
       <div class="cover">
           <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
             {% if entry.has_cover %}
-              <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" />
+              <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" alt="{{ entry.title }}"/>
             {% else %}
-              <img src="{{ url_for('static', filename='generic_cover.jpg') }}" />
+              <img src="{{ url_for('static', filename='generic_cover.jpg') }}" alt="{{ entry.title }}" />
             {% endif %}
           </a>
       </div>
diff --git a/cps/templates/search.html b/cps/templates/search.html
index 3f705c47..f320d393 100644
--- a/cps/templates/search.html
+++ b/cps/templates/search.html
@@ -16,7 +16,7 @@
       <div class="cover">
         {% if entry.has_cover is defined %}
            <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
-            <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" />
+            <img src="{{ url_for('get_cover', cover_path=entry.path.replace('\\','/')) }}" alt="{{ entry.title }}" />
           </a>
         {% endif %}
       </div>

From c86fa268c29a83fcd9a47eaf66f73d603b636458 Mon Sep 17 00:00:00 2001
From: Jonathan Rehm <jonathan@rehm.me>
Date: Fri, 28 Jul 2017 20:02:53 -0700
Subject: [PATCH 2/5] Fix/remove duplicate id's

---
 cps/templates/detail.html      | 10 +++++-----
 cps/templates/index.html       |  4 ++--
 cps/templates/search_form.html |  6 +++---
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/cps/templates/detail.html b/cps/templates/detail.html
index 2859d64c..500d47f1 100644
--- a/cps/templates/detail.html
+++ b/cps/templates/detail.html
@@ -17,7 +17,7 @@
           {% if g.user.role_download() %}
             <div class="btn-group" role="group">
             {% if entry.data|length < 3 %}
-              <button id="btnGroupDrop1" type="button" class="btn btn-primary">
+              <button type="button" class="btn btn-primary">
                 {{_('Download')}} :
               </button>
                 {% for format in entry.data %}
@@ -44,11 +44,11 @@
             {% endif %}
           {% if (g.user.role_download() and g.user.is_anonymous()) or g.user.is_authenticated %}
               <div class="btn-group" role="group">
-                <button id="btnGroupDrop2" type="button" class="btn btn-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+                <button id="read-in-browser" type="button" class="btn btn-primary dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
                   <span class="glyphicon glyphicon-eye-open"></span> {{_('Read in browser')}}
                   <span class="caret"></span>
                 </button>
-                <ul class="dropdown-menu" aria-labelledby="btnGroupDrop2">
+                <ul class="dropdown-menu" aria-labelledby="read-in-browser">
                   {% for format in entry.data %}
                   {%if format.format|lower == 'epub' or format.format|lower == 'txt' or format.format|lower == 'pdf' or format.format|lower == 'cbr' or format.format|lower == 'cbt' or format.format|lower == 'cbz' %}
                   <li><a target="_blank" href="{{ url_for('read_book', book_id=entry.id, book_format=format.format|lower) }}">{{format.format}}</a></li>
@@ -184,11 +184,11 @@
       {% if g.user.shelf.all() or g.public_shelfes %}
       <div id="shelf-actions" class="btn-toolbar" role="toolbar">
         <div class="btn-group" role="group" aria-label="Add to shelves">
-          <button id="btnGroupDrop2" type="button" class="btn btn-primary btn-sm dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+          <button id="add-to-shelf" type="button" class="btn btn-primary btn-sm dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
             <span class="glyphicon glyphicon-list"></span> {{_('Add to shelf')}}
             <span class="caret"></span>
           </button>
-          <ul id="add-to-shelves" class="dropdown-menu" aria-labelledby="btnGroupDrop2">
+          <ul id="add-to-shelves" class="dropdown-menu" aria-labelledby="add-to-shelf">
             {% for shelf in g.user.shelf %}
               {% if not shelf.id in books_shelfs and shelf.is_public != 1 %}
                 <li>
diff --git a/cps/templates/index.html b/cps/templates/index.html
index c5d156ce..9fb9291f 100755
--- a/cps/templates/index.html
+++ b/cps/templates/index.html
@@ -6,7 +6,7 @@
   <div class="row">
 
     {% for entry in random %}
-    <div id="books_rand" class="col-sm-3 col-lg-2 col-xs-6 book">
+    <div class="col-sm-3 col-lg-2 col-xs-6 book">
       <div class="cover">
           <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
             {% if entry.has_cover %}
@@ -42,7 +42,7 @@
   <div class="row">
     {% if entries[0] %}
     {% for entry in entries %}
-    <div id="books" class="col-sm-3 col-lg-2 col-xs-6 book">
+    <div class="col-sm-3 col-lg-2 col-xs-6 book">
       <div class="cover">
           <a href="{{ url_for('show_book', book_id=entry.id) }}" data-toggle="modal" data-target="#bookDetailsModal" data-remote="false">
             {% if entry.has_cover %}
diff --git a/cps/templates/search_form.html b/cps/templates/search_form.html
index 6dbd17a8..d8c3a07d 100644
--- a/cps/templates/search_form.html
+++ b/cps/templates/search_form.html
@@ -28,7 +28,7 @@
     <div class="form-group">
       <div class="btn-toolbar btn-toolbar-lg" data-toggle="buttons">
         {% for tag in tags %}
-          <label id="tag_{{tag.id}}" class="btn btn-danger tags_click">
+          <label id="exclude_tag_{{tag.id}}" class="btn btn-danger tags_click">
             <input type="checkbox" autocomplete="off" name="exclude_tag" id="exclude_tag" value="{{tag.id}}">{{tag.name}}</input>
           </label>
         {% endfor %}
@@ -48,7 +48,7 @@
     <div class="form-group">
       <div class="btn-toolbar btn-toolbar-lg" data-toggle="buttons">
         {% for serie in series %}
-          <label id="serie_{{serie.id}}" class="btn btn-danger serie_click">
+          <label id="exclude_serie_{{serie.id}}" class="btn btn-danger serie_click">
             <input type="checkbox" autocomplete="off" name="exclude_serie" id="exclude_serie" value="{{serie.id}}">{{serie.name}}</input>
           </label>
         {% endfor %}
@@ -69,7 +69,7 @@
       <div class="form-group">
         <div class="btn-toolbar btn-toolbar-lg" data-toggle="buttons">
           {% for language in languages %}
-            <label id="language_{{language.id}}" class="btn btn-danger language_click">
+            <label id="exclude_language_{{language.id}}" class="btn btn-danger language_click">
               <input type="checkbox" autocomplete="off" name="exclude_language" id="exclude_language" value="{{language.id}}">{{language.name}}</input>
             </label>
           {% endfor %}

From 0b47958fadf5f4ebfcce31b4a567a43a57e1a457 Mon Sep 17 00:00:00 2001
From: Jonathan Rehm <jonathan@rehm.me>
Date: Fri, 28 Jul 2017 20:03:23 -0700
Subject: [PATCH 3/5] Add lang attribute to html tag

---
 cps/templates/layout.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cps/templates/layout.html b/cps/templates/layout.html
index 4f55631e..2ac909f5 100644
--- a/cps/templates/layout.html
+++ b/cps/templates/layout.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html>
+<html lang="{{ g.user.locale }}">
   <head>
     <title>{{instance}} | {{title}}</title>
     <meta charset="utf-8">

From dde4f6afe27a2d861f08baeee478f0d71347d604 Mon Sep 17 00:00:00 2001
From: Jonathan Rehm <jonathan@rehm.me>
Date: Fri, 28 Jul 2017 20:03:43 -0700
Subject: [PATCH 4/5] Add missing label

---
 cps/templates/layout.html | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cps/templates/layout.html b/cps/templates/layout.html
index 2ac909f5..c094dd4b 100644
--- a/cps/templates/layout.html
+++ b/cps/templates/layout.html
@@ -56,7 +56,8 @@
         {% if g.user.is_authenticated or g.user.is_anonymous() %}
           <form class="navbar-form navbar-left" role="search" action="{{url_for('search')}}" method="GET">
             <div class="form-group input-group input-group-sm">
-              <input type="text" class="form-control" name="query" placeholder="{{_('Search')}}">
+              <label for="query" class="sr-only">{{_('Search')}}</label>
+              <input type="text" class="form-control" id="query" name="query" placeholder="{{_('Search')}}">
               <span class="input-group-btn">
                 <button type="submit" class="btn btn-default">{{_('Go!')}}</button>
               </span>

From ec118c2254516696213ea8d0afc2033198f9d177 Mon Sep 17 00:00:00 2001
From: Jonathan Rehm <jonathan@rehm.me>
Date: Fri, 28 Jul 2017 20:07:10 -0700
Subject: [PATCH 5/5] Move scripts to bottom of body to prevent execution from
 delaying DOM rendering

---
 cps/templates/layout.html | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/cps/templates/layout.html b/cps/templates/layout.html
index c094dd4b..4f6f7959 100644
--- a/cps/templates/layout.html
+++ b/cps/templates/layout.html
@@ -19,28 +19,9 @@
       <script src="https://oss.maxcdn.com/libs/respond.js/1.3.0/respond.min.js"></script>
     <![endif]-->
 
-    <!-- jQuery (necessary for Bootstrap's JavaScript plugins) -->
-    <!--script src="https://code.jquery.com/jquery.js"></script-->
-    <script src="{{ url_for('static', filename='js/libs/jquery.min.js') }}"></script>
-    <!-- Include all compiled plugins (below), or include individual files as needed -->
-    <script src="{{ url_for('static', filename='js/libs/bootstrap.min.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/libs/underscore-min.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/libs/intention.min.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/libs/context.min.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/libs/plugins.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/libs/jquery.form.js') }}"></script>
-    <script src="{{ url_for('static', filename='js/main.js') }}"></script>
-
     {% block header %}{% endblock %}
   </head>
   <body>
-    <script>
-      $(document).ready(function(){
-        $("#btn-upload").change(function() {
-          $("#form-upload").submit();
-        });
-      });
-    </script>  
     <!-- Static navbar -->
     <div class="navbar navbar-default navbar-static-top" role="navigation">
       <div class="container-fluid">
@@ -217,6 +198,26 @@
       </div>
     </div>
     {% block modal %}{% endblock %}
+
+    <!-- jQuery (necessary for Bootstrap's JavaScript plugins) -->
+    <!--script src="https://code.jquery.com/jquery.js"></script-->
+    <script src="{{ url_for('static', filename='js/libs/jquery.min.js') }}"></script>
+    <!-- Include all compiled plugins (below), or include individual files as needed -->
+    <script src="{{ url_for('static', filename='js/libs/bootstrap.min.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/libs/underscore-min.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/libs/intention.min.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/libs/context.min.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/libs/plugins.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/libs/jquery.form.js') }}"></script>
+    <script src="{{ url_for('static', filename='js/main.js') }}"></script>
+    <script type="text/javascript">
+        $(function() {
+            $("#btn-upload").change(function() {
+                $("#form-upload").submit();
+            });
+        });
+    </script>
+
     {% block js %}{% endblock %}
   </body>
 </html>