Archives/bat
2
0
Fork 0
mirror of https://github.com/sharkdp/bat synced 2024-11-16 21:25:56 +00:00
Code Issues Projects Releases Wiki Activity

Tests ~ echo has portability issues; for CI, replace with printf

Browse Source 
- using `echo` on 'windows' platforms requires process execution indirectly via the shell
- `printf` is available on all GHA CI platforms
  - `printf` is *not* available on usual 'windows' platforms; so this is just temporizing, awaiting a true fix
This commit is contained in:
Roy Ivy III 2020-05-26 21:08:24 -05:00 committed by David Peter
parent 9cc8e52512
commit 3a7743ffc5
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/examples/bat.conf vendored
View File

@ -2,4 +2,4 @@
--paging=always
# Output a dummy message for the integration test.
--pager="echo dummy-pager-from-config"
--pager="printf dummy-pager-from-config"

14
tests/integration_tests.rs
View File

@ -372,30 +372,30 @@ fn do_not_exit_directory() {
#[test]
fn pager_basic() {
bat()
.env("PAGER", "echo pager-output")
.env("PAGER", "printf pager-output")
.arg("--paging=always")
.arg("test.txt")
.assert()
.success()
.stdout("pager-output\n");
.stdout("pager-output");
}
#[test]
fn pager_overwrite() {
bat()
.env("PAGER", "echo other-pager")
.env("BAT_PAGER", "echo pager-output")
.env("PAGER", "printf other-pager")
.env("BAT_PAGER", "printf pager-output")
.arg("--paging=always")
.arg("test.txt")
.assert()
.success()
.stdout("pager-output\n");
.stdout("pager-output");
}
#[test]
fn pager_disable() {
bat()
.env("PAGER", "echo other-pager")
.env("PAGER", "printf other-pager")
.env("BAT_PAGER", "")
.arg("--paging=always")
.arg("test.txt")
@ -421,7 +421,7 @@ fn config_read_arguments_from_file() {
.arg("test.txt")
.assert()
.success()
.stdout("dummy-pager-from-config\n");
.stdout("dummy-pager-from-config");
}
#[test]