Don't crash on comment for asciicast without user

openid
Marcin Kulik 12 years ago
parent 06e7314f23
commit a57d05597e

@ -38,7 +38,7 @@ class Api::CommentsController < ApplicationController
end
def notify_via_email(user, comment)
if user.email.present? && user != comment.user
if user && user.email.present? && user != comment.user
UserMailer.new_comment_email(user, comment).deliver
end
end

@ -141,5 +141,14 @@ describe Api::CommentsController do
@controller.send(:notify_via_email, user, comment)
end
end
context 'when asciicast author is unknown (nil)' do
let(:user) { nil }
it "doesn't send email" do
UserMailer.should_not_receive(:new_comment_email)
@controller.send(:notify_via_email, user, comment)
end
end
end
end

Loading…
Cancel
Save