Commit Graph

261 Commits (e145ca6eed2bd4b4047a14dde66ebe82786604d8)

Author SHA1 Message Date
Soner Tari e145ca6eed Refactor add/remove conn/child code
Fix whitespace
6 years ago
Soner Tari cc0b94c17f Do not do anything with the conn ctx on the thrmgr thread after setting event callbacks and/or socket connect
Always lock conn thr while reading ctx fields, otherwise we may get wrong values
6 years ago
Soner Tari c43e359a1b Do not modify thr stats without locking, otherwise max fd stats were sometimes wrong 6 years ago
Soner Tari 3147723774 Add attribs, enclose debug params between debug macros, and improve documentation 6 years ago
Soner Tari dcaaa49f90 Improve documentation and use better names 6 years ago
Soner Tari 79ad5e86cc Fix expired conn handling, signal 6 crash: Do not lock conn thr mutex twice while freeing expired conns
Fix passthrough mode: Do not SSL_free() srvdst ssl anymore and do not add conn to thr conns list twice
6 years ago
Soner Tari bf513b1c37 Improvements 6 years ago
Soner Tari 844e68116a Move userauth from thrmgr thread to conn handling threads, and do not enable r/w callbacks until userauth succeeds
Lock conn thread instead of thrmgr thread while adding conns (giant thrmgr lock versus conn thread level locks), so add conn thread mutex and remove thrmgr mutex
Offload thrmgr thread by moving many conn related setup to conn handling threads
Fix signal 6 crash caused by calling pxy_thrmgr_timer_cb() while failed conn is being freed, so use conn thread mutexes and defer adding conn to thr conn list until conn setup succeeds
Other fixes, improvements, and clean-up
6 years ago
Soner Tari 2f3fda5367 Do not try to close conns on the thrmgr thread after setting event callbacks and/or socket connect
Use strncpy() instead of memcpy(), to limit max size with dest buffer
6 years ago
Soner Tari 7b11eb15fa Update copyright year to 2019 6 years ago
Soner Tari 7eb0ebc814 Refactor fd usage code for code reuse 6 years ago
Soner Tari 56c3bdf5d8 Do not try to term/close conns on the thrmgr thread after setting event callbacks and/or socket connect 6 years ago
Soner Tari 76a599d464 Put the getdtablecount() solution back in, otherwise sometimes, although rarely, we get "Error 24 on listener: Too many open files" nonstop, it's better to be safe(r) 6 years ago
Soner Tari 96ecd8e4c3 Pass BEV_OPT_THREADSAFE to bufferevent_socket_new() and similar functions, otherwise if we are out of fds, we get signal 10 or 6 crashes sometimes, nothing else seems to work 6 years ago
Soner Tari 3a6f797917 Do not forget to reset sqlite stmt if userdb is busy or locked, otherwise we get stuck and go out of fds too
Check retval of event_add() calls
Reduce frequency of userdb atime updates by not updating until idle time reaches more than half of user timeout value, otherwise privsep server can get very busy causing locked userdb
Do not care about multiple matches of IP addresses in arp cache on OpenBSD either
Performance and code reuse improvements, simplifications
6 years ago
Soner Tari 0d49ba56db Enable user auth support on Linux 6 years ago
Soner Tari 4f4b41d5ad Add user and proto validation info to connection logs 6 years ago
Soner Tari b6f2203495 Validate proxyspec protocols http, pop3, and smtp 6 years ago
Soner Tari 6f37661772 Enable user auth for all supported protos or proxyspec types 6 years ago
Soner Tari c37bcc6de1 Add UserDBPath and UserTimeout options 6 years ago
Soner Tari fd52ba0c56 Refactor, handle error conditions, and clean up 6 years ago
Soner Tari cde3fbca3f Redirect user to login page and redirect again to orig target after successful authentication, currently supported only on OpenBSD
Get ethernet address and compare with the one in userdb, on each conn setup
Create user_auth options
Rename and clean-up
6 years ago
Soner Tari fb25c45c66 Clean-up 6 years ago
Soner Tari 304207e9e9 Add initial user database support using sqlite3 6 years ago
Soner Tari e132b12d79 Support remote listening programs using ua and ra proxyspec options, address of remote listening program that decrypted packets are diverted to and address SSLproxy is listening for returned packets from remote listening program, respectively 6 years ago
Soner Tari 87403615f9 Remove now unnecessary UNUSED attributes 6 years ago
Soner Tari 670f609d7a Refactor logging code and fix memory leak 6 years ago
Soner Tari 70a22f4515 Do not break the event loop if out of fds, instead properly check all retvals of libevent functions
So remove getdtable*() solution
6 years ago
Soner Tari f848248f54 Use better names and fix white space 6 years ago
Soner Tari d0687b3398 Fix double init of protoctx, memory leak
Free vars where they are allocated, always
6 years ago
Soner Tari 3f148cf3b9 Move thrmgr->conn_count inc for conn id back to conn acceptcb, because acceptcb runs on thrmgr thread which is single threaded, so there is no multithreading issues there 6 years ago
Soner Tari 360b951ade Prevent possible multithreading issues, which would not cause crashes but incorrect conn ids and memory leaks due to broken thread conn linked lists 6 years ago
Soner Tari 3fd02eee9d Use available_fds() on osx to detect out of file descriptors condition, borrowed from opensmtpd 6 years ago
Soner Tari e1d96a874e Disable getdtablecount() on osx, temporarily 6 years ago
Soner Tari 7847486bc4 Try to fix travis osx build, osx does not have getdtablecount() either 6 years ago
Soner Tari 77b81aa45f Fix travis osx build 6 years ago
Soner Tari 52d37297b6 Update with sslsplit develop changes, especially content logging
Change SIGHUP to behave like SIGUSR1
6 years ago
Soner Tari 12ecc96648 Assume co-ownership of refactored and new pxy and proto source files by adding copyright line below the original copyright line 6 years ago
Soner Tari 87eb6ce004 Move conn end free function callback to conn end struct, proto ctx should not keep track of such conn end details, conn end should know which function to be called to free itself, we may have different protos on different ends of the same conn
Improve and clean up
6 years ago
Soner Tari 5351e78740 Combine term and enomem handling code and improve 6 years ago
Soner Tari ca959ca391 Do not call topmost callback functions directly, use them in bufferevent setup only, otherwise can possibly cause double free of ctx
Run preexec and postexec logging and/or stats code when calling interface callback functions directly, they are mostly called in edge cases, but otherwise we would miss related logs and/or stats
6 years ago
Soner Tari 3d668aabb6 Minor improvements 6 years ago
Soner Tari cd78d881c8 Fix passthrough mode double free crash and free any/all data of previous proto asap
Improve and clean up
6 years ago
Soner Tari e8e8071772 Defer conn free until the exit code of topmost callback functions, for both parent and child connections, this is necessary to handle error conditions correctly and terminate connections gracefully
So introduce term flags in ctx and replace free functions with term functions to raise the term flag, this approach enables us to terminate connection anywhere in the code without causing use after free crashes
Improve and clean up
6 years ago
Soner Tari c085cafe0f Rename srv_dst to srvdst
Clean up
6 years ago
Soner Tari adb99db518 Handle out of memory conditions correctly
Do not do anything else with ctx while returning from topmost callback functions if it is freed
Rename functions, improve, and clean up
6 years ago
Soner Tari cbb9d593c4 Do not do anything else with ctx while returning from topmost callback functions if it is freed
Handle out of memory conditions correctly
6 years ago
Soner Tari 2aeec751e0 Handle out of memory conditions correctly 6 years ago
Soner Tari 2f0e574f09 Fix autossl, but Evolution client sometimes does not send ehlo, especially after user rejects self-signed cert, which needs further investigation
And other improvements
6 years ago
Soner Tari c91d569723 Improve debug logging, log proto name on connect/disconnect
Rename vars and functions
Improve and clean up
6 years ago