Commit Graph

30 Commits (e145ca6eed2bd4b4047a14dde66ebe82786604d8)

Author SHA1 Message Date
Soner Tari cc0b94c17f Do not do anything with the conn ctx on the thrmgr thread after setting event callbacks and/or socket connect
Always lock conn thr while reading ctx fields, otherwise we may get wrong values
6 years ago
Soner Tari 3147723774 Add attribs, enclose debug params between debug macros, and improve documentation 6 years ago
Soner Tari 79ad5e86cc Fix expired conn handling, signal 6 crash: Do not lock conn thr mutex twice while freeing expired conns
Fix passthrough mode: Do not SSL_free() srvdst ssl anymore and do not add conn to thr conns list twice
6 years ago
Soner Tari 844e68116a Move userauth from thrmgr thread to conn handling threads, and do not enable r/w callbacks until userauth succeeds
Lock conn thread instead of thrmgr thread while adding conns (giant thrmgr lock versus conn thread level locks), so add conn thread mutex and remove thrmgr mutex
Offload thrmgr thread by moving many conn related setup to conn handling threads
Fix signal 6 crash caused by calling pxy_thrmgr_timer_cb() while failed conn is being freed, so use conn thread mutexes and defer adding conn to thr conn list until conn setup succeeds
Other fixes, improvements, and clean-up
6 years ago
Soner Tari 2f3fda5367 Do not try to close conns on the thrmgr thread after setting event callbacks and/or socket connect
Use strncpy() instead of memcpy(), to limit max size with dest buffer
6 years ago
Soner Tari 7b11eb15fa Update copyright year to 2019 6 years ago
Soner Tari 56c3bdf5d8 Do not try to term/close conns on the thrmgr thread after setting event callbacks and/or socket connect 6 years ago
Soner Tari 6f37661772 Enable user auth for all supported protos or proxyspec types 6 years ago
Soner Tari 670f609d7a Refactor logging code and fix memory leak 6 years ago
Soner Tari 70a22f4515 Do not break the event loop if out of fds, instead properly check all retvals of libevent functions
So remove getdtable*() solution
6 years ago
Soner Tari 52d37297b6 Update with sslsplit develop changes, especially content logging
Change SIGHUP to behave like SIGUSR1
6 years ago
Soner Tari 12ecc96648 Assume co-ownership of refactored and new pxy and proto source files by adding copyright line below the original copyright line 6 years ago
Soner Tari 87eb6ce004 Move conn end free function callback to conn end struct, proto ctx should not keep track of such conn end details, conn end should know which function to be called to free itself, we may have different protos on different ends of the same conn
Improve and clean up
6 years ago
Soner Tari ca959ca391 Do not call topmost callback functions directly, use them in bufferevent setup only, otherwise can possibly cause double free of ctx
Run preexec and postexec logging and/or stats code when calling interface callback functions directly, they are mostly called in edge cases, but otherwise we would miss related logs and/or stats
6 years ago
Soner Tari 3d668aabb6 Minor improvements 6 years ago
Soner Tari cd78d881c8 Fix passthrough mode double free crash and free any/all data of previous proto asap
Improve and clean up
6 years ago
Soner Tari d4a209cbfb Avoid redundant void to ctx type casts by passing ctx explicitly 6 years ago
Soner Tari e8e8071772 Defer conn free until the exit code of topmost callback functions, for both parent and child connections, this is necessary to handle error conditions correctly and terminate connections gracefully
So introduce term flags in ctx and replace free functions with term functions to raise the term flag, this approach enables us to terminate connection anywhere in the code without causing use after free crashes
Improve and clean up
6 years ago
Soner Tari c085cafe0f Rename srv_dst to srvdst
Clean up
6 years ago
Soner Tari adb99db518 Handle out of memory conditions correctly
Do not do anything else with ctx while returning from topmost callback functions if it is freed
Rename functions, improve, and clean up
6 years ago
Soner Tari c91d569723 Improve debug logging, log proto name on connect/disconnect
Rename vars and functions
Improve and clean up
6 years ago
Soner Tari 1374d37722 Decouple stats from proto code
Move connect logging to the topmost callback functions, amap
Improve and clean up
6 years ago
Soner Tari 0c2d12f35d Decouple connect logging from proxy code
Improve and clean up
6 years ago
Soner Tari 3e0cbc2905 Rearrange and clean up 6 years ago
Soner Tari 59c11017bd Refactor to move common logging and stats code to topmost callback functions
Log only orig content in the topmost readcb
Improve and clean up
6 years ago
Soner Tari 13040639b7 Add static and NONNULL attrib
Rename, improve, and clean up
6 years ago
Soner Tari f681b31497 Decouple ssl from tcp and other protocols
Improve and clean up
6 years ago
Soner Tari 0c55600ec7 Move ssl proto to its own file, but still needs more refactoring to decouple ssl from other protocols, especially tcp
Rename and clean up
6 years ago
Soner Tari 8fc9b0a44d Move tcp proto to its own file
Rename and clean up
6 years ago
Soner Tari b10643908f Move passthrough proto to its own file
Rename and clean up
6 years ago