You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
e3c639a09f
This switch has been a pain for years. Often disabling broke compilation, as no developer compiles OpenTTD without, neither do any of our official binaries. Additionaly, it has grown so hugely in our codebase, that it clearly shows that the current solution was a poor one. 350+ instances of "#ifdef ENABLE_NETWORK" were in the code, of which only ~30 in the networking code itself. The rest were all around the code to do the right thing, from GUI to NewGRF. A more proper solution would be to stub all the functions, and make sure the rest of the code can simply assume network is available. This was also partially done, and most variables were correct if networking was disabled. Despite that, often the #ifdefs were still used. With the recent removal of DOS, there is also no platform anymore which we support where networking isn't working out-of-the-box. All in all, it is time to remove the ENABLE_NETWORK switch. No replacement is planned, but if you feel we really need this option, we welcome any Pull Request which implements this in a way that doesn't crawl through the code like this diff shows we used to. |
5 years ago | |
|---|---|---|
| .. | ||
| core | 5 years ago | |
| network.cpp | 5 years ago | |
| network.h | 5 years ago | |
| network_admin.cpp | 5 years ago | |
| network_admin.h | 5 years ago | |
| network_base.h | 5 years ago | |
| network_chat_gui.cpp | 5 years ago | |
| network_client.cpp | 5 years ago | |
| network_client.h | 5 years ago | |
| network_command.cpp | 5 years ago | |
| network_content.cpp | 5 years ago | |
| network_content.h | 5 years ago | |
| network_content_gui.cpp | 5 years ago | |
| network_content_gui.h | 9 years ago | |
| network_func.h | 5 years ago | |
| network_gamelist.cpp | 5 years ago | |
| network_gamelist.h | 15 years ago | |
| network_gui.cpp | 5 years ago | |
| network_gui.h | 5 years ago | |
| network_internal.h | 5 years ago | |
| network_server.cpp | 5 years ago | |
| network_server.h | 5 years ago | |
| network_type.h | 5 years ago | |
| network_udp.cpp | 5 years ago | |
| network_udp.h | 5 years ago | |