Version: Committing version data for tag: jgrpp-0.58.3

See: #681
See: https://github.com/OpenTTD/OpenTTD/issues/12465

.ottdrev-vc

@@ -1,2 +1,2 @@
-jgrpp-0.58.2	20240328	0	64a67d8821b190934b89cf86f9113414927e9cfc	1	0	2024
-3ee6e8b554665d66faffae2f50bf57e5e74e66ac4983062b0480695ff21d8bb1  -
+jgrpp-0.58.3	20240410	0	6642b7e12c203cba63246d57db760bf9c521769e	1	0	2024
+ec66ffa6cab681f8f7d8bc388aaaac7e772591a41201d4854d07dcd7378ecac3  -

README.md

@@ -1,4 +1,4 @@
-## JGR's Patchpack version 0.58.2
+## JGR's Patchpack version 0.58.3
 
 This is a collection of patches applied to [OpenTTD](http://www.openttd.org/)
 

jgrpp-changelog.md

@@ -2,6 +2,21 @@
 
 * * *
 
+### v0.58.3 (2024-04-10)
+* Fix stuttering when playing sound effects on Windows.
+* Fix incorrect cargo payment calculations for cargo in the mail compartment of aircraft and in non-first parts of multi-part ships.
+* Fix path-only signal cycle mode being ignored when using realistic braking.
+* Template-based train replacement:
+  * Fix replacement failing when using NewGRFs with complex wagon attachment and/or start/stop restrictions.
+  * Fix incorrect cost estimation when using NewGRFs with complex start/stop restrictions.
+* Wallclock timekeeping mode:
+  * Fix game units (tiles/second) being shown as tiles/day.
+  * Fix time units shown for past production in the industry window.
+* Fix cargo dist effect of distance on demand setting for values greater than 100%. (The scaling/demand allocation algorithm has been adjusted in general).
+* Fix velocity units used in cargo payments graph x-axis label.
+* Fix click/tooltip alignment of cargo lines in the industry chains window.
+* Fix changing sprite alignments in the sprite aligner window not being applied as expected.
+
 ### v0.58.2 (2024-03-28)
 * Fix crash with some GRFs when the maximum sprite resolution setting was set to 2x.
 * Fix crash which could occur when clearing a crashed road vehicle from a drive-through road stop.

src/industry_gui.cpp

@@ -2354,11 +2354,11 @@ struct CargoesField {
 		}
 		/* col = 0 -> left of first col, 1 -> left of 2nd col, ... this->u.cargo.num_cargoes right of last-col. */
 
-		int vpos = vert_inter_industry_space / 2 + CargoesField::cargo_border.width;
+		int vpos = (vert_inter_industry_space / 2) + (CargoesField::cargo_border.width / 2);
 		uint row;
 		for (row = 0; row < MAX_CARGOES; row++) {
 			if (pt.y < vpos) return INVALID_CARGO;
-			if (pt.y < vpos + GetCharacterHeight(FS_NORMAL)) break;
+			if (pt.y < vpos + (int)CargoesField::cargo_line.height) break;
 			vpos += GetCharacterHeight(FS_NORMAL) + CargoesField::cargo_space.width;
 		}
 		if (row == MAX_CARGOES) return INVALID_CARGO;
@@ -2694,9 +2694,7 @@ struct IndustryCargoesWindow : public Window {
 		}
 	}
 
-
-	CargoesFieldType type; ///< Type of field.
-	void SetStringParameters  (WidgetID widget) const override
+	void SetStringParameters(WidgetID widget) const override
 	{
 		if (widget != WID_IC_CAPTION) return;