Commit Graph

25 Commits (9fd91f9b69a60e6cd9380f7671b5c5256075dbb7)

Author SHA1 Message Date
Charles Pigott 644f4c3547 Codechange: Set size of SettingGuiFlag & SettingDescType enums, and use them properly 5 years ago
peter1138 c0836bccef Codechange: NULL -> nullptr in settings files. 5 years ago
Patric Stout e3c639a09f Remove: ENABLE_NETWORK switch
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.

Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.

A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.

With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.

All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
5 years ago
Peter Nelson 9de12521ec Codechange: Convert saveload numbers to enum values.
(This was mostly achieved with a few in-place regexes)
5 years ago
Peter Nelson ea4ea62816 Codechange: Make saveload version upper bound exclusive, i.e. version object was removed instead of version object last appeared. 5 years ago
frosch 7247ecf172 (svn r26206) -Fix [FS#5829]: Run everything from ini, obg, obs, obs, ... files through str_validate. 11 years ago
rubidium f9c9ff6ec3 (svn r25508) -Change: split unit localisation choice into a choice per type of unit, and move it to the advanced settings
-Feature [FS#5482]: have tractive effort in imperial (lbf) and metric (kgf) units
-Feature: have weights and volumes in imperial units (short tons, gallons)
11 years ago
planetmaker c22bbf5293 (svn r25072) -Codechange: Don't require the custom currency to be the last defined one 11 years ago
frosch 21b43b63f5 (svn r24843) -Codechange: Move news display options into the general settings framework. (based on patch by eagle_rainbow) 12 years ago
frosch d1ab0f03bc (svn r24790) -Remove: Classic difficulty profiles. 12 years ago
frosch 812ae4140a (svn r24789) -Add: Separate setting to control the default settings of newly added scripts and random AIs. 12 years ago
frosch a499435351 (svn r24786) -Codechange: Add SettingsProfile enum for difficulty profiles and highscore tables. 12 years ago
frosch 5b2da98ca3 (svn r24785) -Add: Various methods to open the OSK. (based on patch by Eagle_rainbow) 12 years ago
frosch 69a62452be (svn r24671) -Feature [FS#5355]: Add basic/advanced/expert filters to adv. settings GUI. (Eagle_rainbow) 12 years ago
alberth 1d58838a97 (svn r24234) -Add: Add help-string infrastructure to the ini files 12 years ago
rubidium bf55f58a47 (svn r23326) -Fix [FS#4852] (r23239): snow line for very old savegames wasn't retrieved from the savegame anymore 13 years ago
rubidium 1de7127d62 (svn r23239) -Fix: saving/loading the snow line height twice, especially when the values are not the same causes some nasty problems... like desyncs 13 years ago
rubidium 47c5d30b5d (svn r23084) -Codechange: get rid of a redundant variable 13 years ago
alberth 9fe65f93fe (svn r22210) -Add: Add a variable for the value strings in the settings tables. 14 years ago
alberth bbde7766d2 (svn r22207) -Add: Add the copyright message to the new ini files. 14 years ago
rubidium b8d3c42de2 (svn r22199) -Cleanup-ish: replace the shortcut macros for (gui)flags with their more clearly named (longer) constant names 14 years ago
rubidium 2636a4809b (svn r22197) -Cleanup: remove the distinction between conditional and non-conditional settings; with default from and to savegame versions all can be conditional. They previously were as well; the non-conditional ones were macros of the conditionals with to/from saveload versions hardcoded 14 years ago
rubidium cb3fa759f3 (svn r22196) -Codechange: use default values for the from and to of savegame versions as well 14 years ago
rubidium 8b9f99ec44 (svn r22194) -Codechange: use the defaults feature of settingsgen to remove the need to state the "default" value for all items 14 years ago
alberth 74d756799c (svn r22172) -Add: Add ini files containing the table/settings data. 14 years ago