ea73b46684
(svn r3597) Miscellaneous (I like that word) changes: Fix some indentation, add consts, reduce indentation level by short-circuit logic, convert if cascades to switch, whitespace, bracing, plus some minor stuff
19 years ago
453b30e387
(svn r3564) Several smaller changes:
...
- Don't treat non-booleans as booleans
- Reduce variable scope
- Bracing
- Use DeMorgan's law to make conditionals easier to read
- if cascade -> switch
- Replace some magic numbers by symbolic names
- Avoid assignments within other statements
19 years ago
84fb96fe85
(svn r3511) More whitespace ([FS#46] by Rubidium)
19 years ago
22dc05faf2
(svn r3510) Fiddle with whitespace and parentheses
19 years ago
5e1e902600
(svn r3490) -Fix: A bunch (10) of off-by-one errors when checking if a TileIndex points to a tile on the map
19 years ago
4e09974975
(svn r3472) - [PBS] Remove from trunk. Anyone interested can still find it in branch/pbs. This reverts revisions r3158, r3140, r3075, r2977, r2674, r2625, r2621, r2529, r2528, r2525, r2524, r2519, r2517, r2516, r2507, r2499. (in conjunction with Tron)
...
- The only change is that the nsignalsw.grf file is kept and that existing nightlies with PBS signals get those signals converted to combo-signals.
19 years ago
f4e7d3203a
(svn r3466) - Codechange: Some changes to increase readability of signals code.
19 years ago
de34ab97a2
(svn r3389) -Fix: No fence was placed when placing fences and the neighbouring tile is a rail configuration which permits a fence but has a signal
...
(Per request of peter1138 the above line does not contain any commas)
19 years ago
18de531671
(svn r3387) Restructure the code, which places fences along railroad tracks.
...
This includes no functional changes, just some cleanup before some bugfix
19 years ago
08a3e346cd
(svn r3369) - Codechange: Replace tables _signals_table, _signals_table_other and _signals_table_both by the equivalent calls to rail.h functions.
...
- Codechange: Add a few constants.
19 years ago
e272b03fee
(svn r3365) Staticise 36 functions
19 years ago
bf98086de8
(svn r3298) Remove unused and write-only variables
19 years ago
23bfc03054
(svn r3297) Staticise
19 years ago
809b03c81a
(svn r3282) - Codechange: Replace tests against CMD_ERROR with CmdFailed()
19 years ago
754d26407e
(svn r3212) - Waypoints/Depots: Store waypoint index in m2 for waypoints. This moves the ground type bits from m2 to m4 for waypoints and depots (leaving room for depot index in m2 in future), and moves the custom graphics ID to the waypoint struct.
...
- Waypoints: Until now stat_id was saved but never assigned to. Instead we now save the GRFID/local index of the custom graphics so that GRF file changes can leave graphics intact.
19 years ago
c1b012171d
(svn r3210) -Codechange: use IsRailWaypoint where possible (instead of magicnumbers)
...
-Codechange: IsRailWaypoint should take 'tile', not 'm5'
19 years ago
b739674307
(svn r3209) In TileLoop_Track(), use names based on function rather than their place in the map array.
19 years ago
24f857ed5e
(svn r3187) Simplify overly complicated ifs, especially if (foo) return false; else return true; is confusing
19 years ago
1b0091e0d2
(svn r3184) GB/SB
19 years ago
f7abff5f96
(svn r3181) -Bracing
...
-Indentation
-Whitespace
-DeMorgan's Law
-Test with NULL or 0 for non-booleans
-'\0' instead of 0 for chars
-Remove redundantly redundant comments (like DoFoo(); // Do foo)
-Join multiple short lines with a single statement
-Split single lines with multiple statements
-Avoid assignments in if
19 years ago
4a14a586e2
(svn r3173) Use the trinary operator and switch to improve readability
...
Also align short cases nicely
19 years ago
a7fe1495cd
(svn r3168) - NewGRF: Fix "typo" in waypoint drawer :/
19 years ago
b1075ca7a4
(svn r3166) Constify read-only accesses of custom stations
19 years ago
49335b4daa
(svn r3141) Replace incorrect railtype bitmask in CmdRailTrackHelper with appropriate GB()
19 years ago
47137cefb7
(svn r3078) Some more stuff, which piled up:
...
- const, whitespace, indentation, bracing, GB/SB, pointless casts
- use the trinary operator where appropriate
- data types (uint[] -> AcceptedCargo, ...)
- if cascade -> switch
- if (ptr) -> if (ptr != NULL)
- DeMorgan's Law
- Fix some comments
- 0 -> '\0', change magic numbers to symbolic constants
19 years ago
2cc2154ad2
(svn r3077) static, const, bracing, indentation, 0 -> '\0'/NULL, typos in comments, excess empty lines, minor other changes
...
nothing spectacular, just some stuff, which piled up
19 years ago
2b91f55b32
(svn r3073) int/byte -> EngineID/PlayerID/VehicleID
...
0/-1 -> INVALID_ENGINE
0x10 -> OWNER_NONE
19 years ago
ece9b9b2b6
(svn r3066) Constify the parameter of GetSlopeZ_*()
19 years ago
66bf4f863d
(svn r3049) Replace byte/int/uint by RailType where appropriate
19 years ago
76db75d81a
(svn r3028) s/255/OWNER_SPECTATOR/
19 years ago
9134e19d7e
(svn r3025) -Fix: Rail convert issue introduced in r3019
19 years ago
ae4a1f3675
(svn r3019) -Codechange: Replace explicit shifting/anding/oring with GB and SB
19 years ago
f8d1267d71
(svn r2998) -Codechange: Split rail drawing code off from DrawTile_Rail into a separate function to be used elsewhere. (Deja vu?)
19 years ago
8e6a911700
(svn r2962) - const correctness for all Get* functions and most Draw* functions that don't change their pointer parameters
...
- change a lot of byte player types to PlayerID
- beautify header files, same "#endif /* filename */" ending
19 years ago
2131f68ae2
(svn r2951) - Fix: [ 1259345 ] Changing engine in netgame opens train window for everyone
...
- Add IsLocalPlayer() which substitutes _local_player == _current_player
19 years ago
2e87864d0b
(svn r2948) -Fix: the old AI needs a special flag that triggers all kind of special
...
abilities you really don't want to know about (free bridges, etc..)
I removed this flag some revisions ago, but the Aircraft part
depends on it, so I re-enabled it again..
19 years ago
f914a7eca6
(svn r2890) Fix some signed/unsigned comparison warnings (tokai)
19 years ago
29564f9fcf
(svn r2781) Fix some of the issues with variables in .h files.
19 years ago
fcf5ace08f
(svn r2774) -Codechange: Removed TRACKTYPE_SPRITE_PITCH globally and replaced it by a member of RailtypeInfo
19 years ago
24986e9144
(svn r2756) Renamed railtypes into _railtypes
...
Renamed railtypes.c into railtypes.h, all other tables are in .h files. (It should be in the tables dir but I couldn't figure out how to get it there without deleting it first).
Added const and extern.
19 years ago
1736566e22
(svn r2753) -Codechange: Introduced a new struct "RailtypeInfo" to store rail type specific information. Begun populating it with a bunch of sprites, more to come later. This should result in cleaner, more compact code which allows easy introduction of new railtypes.
19 years ago
238e47cd42
(svn r2702) -Codechange: Cleaned up the sprite code and replaced many magic numbers
...
by enums. There remains work in gfx.c to move the "transparency" and
"recolor" bits around to make space for more sprites. However, 2800
additional sprites can now be loaded. There also remains cleanup and
Doxygen work on many of the header files.
19 years ago
a227065ab7
(svn r2701) Insert Id tags into all source files
19 years ago
559babcdc9
(svn r2673) Include functions.h directly, not globally via openttd.h
19 years ago
85f06d6e7b
(svn r2658) -Codechange: Use MAKE_TRANSPARENT to display a transparented sprite
19 years ago
ac66e3e28f
(svn r2650) Convert many explicit shifts+ands to extract bits to invocations of GB - should be a bit nicer to read
19 years ago
edbe969d23
(svn r2621) - Fix: [pbs] When removing tracks, clear their reserved status.
19 years ago
9ca761b065
(svn r2595) -Codechange: Introduced "IsSteepTileh" to find whether a tile is steep
...
(i.e. spans two height levels) and use it throughout the code.
-Codechange: Add CanBuildDepotByTileh to find if a tile is suitable to
build a depot on it. Wraps some bitmagic which seems quite unreadable at
first glance
19 years ago
8c1d74162f
(svn r2558) Change the internal map format from 7 arrays to one array of structs, this doesn't change the saved format for now. It's a stepping stone for further changes.
19 years ago
480ced43c9
(svn r2529) - Fix: PBS signals showed up as normal signals with the query tool
...
- Update landscape_grid.html to show busy bits used by PBS.
19 years ago
tron
Darkvater
matthijs
peter1138
truelight
ludde
celestar
hackykid