Commit Graph

70 Commits

Author SHA1 Message Date
richk
d11e36e477 (svn r8978) -Feature: Rewrite of transfer system.
This major feature-fix keeps track of the value of transfers offloaded at a station, and hands on to a loading vehicle a credit note proportionate to the cargo loaded. The transferring vehicle is paid only for the distance it has travelled. eg. B-C in a transfer chain A-B-C-D.
When the final cargo is delivered, these credit notes are cashed, and the final vehicle is paid for A-D minus any credit notes it is carrying. The company bank balance increases by the value of the A-D route.
You still need to set up a profitable route; it is still easy to make a loss on transfers by bad planning. :)
2007-03-02 18:49:11 +00:00
tron
d3b29bcacb (svn r8876) -Fix
Replace tests with magic numbers by a simple extraction template for command parameters
2007-02-24 09:42:39 +00:00
tron
1d1121f85a (svn r8875) -Fix
Remove unnecessary EnsureNoVehicle() checks because they are
- pointless per se (f.e. there are no vehicles on house tiles)
- done again (f.e. using CMD_LANDSCAPE_CLEAR just a few lines later)
2007-02-24 06:46:20 +00:00
belugas
a723770836 (svn r8853) -Cleanup: doxygen changes. Correct forgotten c files to cpp files with the @file tag as well as a few general comments style 2007-02-23 01:48:53 +00:00
rubidium
202702c007 (svn r8852) -Fix (r8735): make the dynamite tool for drive through road stops as if it were removing a normal road tile (consider the local authority and such).
-Fix (r8735): remove drive through road stops on town owned roads when going bankrupt/being removed.
2007-02-23 00:17:46 +00:00
rubidium
dcb217a6ac (svn r8851) -Fix [FS#643] (r8735): crash on removing town owned roads outside of the local authority. 2007-02-23 00:10:16 +00:00
tron
103d119c51 (svn r8841) -Fix
Remove {,u}intswap() and replace them by Swap()
2007-02-22 08:43:02 +00:00
tron
f716c0b30f (svn r8833) -Fix
-Codechange: Split MakeRoadStop() into MakeRoadStop() and MakeDriveThroughRoadStop() for more clarity and less possibilities to use it incorrect
2007-02-21 19:46:37 +00:00
tron
565da62355 (svn r8828) -Fix
-Regression (r7585): On load calculate the station rectangle for all savegames, not just savegames with at least version 27
2007-02-21 07:37:31 +00:00
peter1138
ef2daa5060 (svn r8826) -Codechange: Replace _cargoc's separate arrays with a regular struct array (with accessor) and implement new initialization method using cargo labels. 2007-02-20 22:09:21 +00:00
tron
41d526415c (svn r8822) -Fix
Variable scope, const
2007-02-20 06:39:09 +00:00
rubidium
168a7876a0 (svn r8809) -Fix (r8715): accidentally removed a part of an expression. 2007-02-19 13:45:13 +00:00
tron
352273a5b3 (svn r8800) -Fix
Simplify MoveGoodsToSation() under the assumption that 0 is less or equal than 0
2007-02-18 11:45:56 +00:00
tron
1ed8e7e04e (svn r8799) -Fix
Reduce variable scope
2007-02-18 11:27:09 +00:00
rubidium
0734bcfea0 (svn r8797) -Fix (8741): the 'drive through station built on town owned road' bit was not set. 2007-02-18 11:14:55 +00:00
tron
1a1129785a (svn r8796) -Fix
Remove the unused function AllocateStation() which was left over from r8125
2007-02-18 09:00:34 +00:00
tron
c6743c5e11 (svn r8794) -Fix
Remove the possiblity to take over stations with OWNER_NONE by building a station next to it
-Fix: It was possible to take over buoys by building a station next to them
Also remove the now unnecessary special case which prevented taking over oilrigs
NOTE: 0.5 candidate
2007-02-18 08:37:39 +00:00
tron
ea8eb50c0e (svn r8782) -Fix
Adapt GetClosestStationFromTile() more to the way it is used:
- All but deleted stations get filtered later, so do not include non-deleted station in the first place
- Remove the two parameters, which are the same for all callers
2007-02-17 15:59:33 +00:00
tron
b6d2172678 (svn r8781) -Fix
A spectator cannot build stations, so do not include a special case for him
2007-02-17 15:34:05 +00:00
tron
a74fad50fa (svn r8779) -Fix
-Codechange: Use a more generic test, which tests the allowed aircraft instead of hardcoding the airport type numbers, to generate station names
2007-02-17 15:03:30 +00:00
tron
8aacd2585d (svn r8767) -Fix
-Codechange: Do not hardcode the catchment radius of airports, but hold the information in AirportFTAClass
-Fix (r979): The default AI tested possible airport locations with a fixed catchment radius instead of the radius of the to be built airport
2007-02-17 07:45:18 +00:00
rubidium
c04c8382ca (svn r8765) -Codechange: remove logic redundancy by moving it from the gui into the cmd code. 2007-02-16 22:44:56 +00:00
tron
87e03c7aa8 (svn r8755) -Fix
Abbreviate GetAirport(st->airport_type) to st->Airport()
2007-02-16 09:38:43 +00:00
rubidium
79dda0fa07 (svn r8741) -Fix (r8735): make the saveguards of CmdBuildRoadStop more robust and add roadstops.grf to the list of required grfs. 2007-02-14 20:58:19 +00:00
rubidium
0e8f006dc1 (svn r8735) -Feature: drive-through road stops made possible by the hard work of mart3p. 2007-02-14 16:37:16 +00:00
rubidium
154dff9873 (svn r8715) -Codechange/cleanup: replace magic numbers related to state of road vehicles with enums. Original patch by mart3p. 2007-02-13 22:27:27 +00:00
celestar
d9385f2798 (svn r8709) -Fix/Codechange: Rename the function GetStationPlatforms into GetPlatformLength because that is what it really does. Overload it because there is already a GetPlatformLength (one gives the length of the whole platform, the other gives the remaining length in a given direction). Turned both functions into methods of Station. While messing around with it, fix a problem where loading times for overhanging trains are miscomputed. 2007-02-13 16:36:38 +00:00
celestar
8eab3964b4 (svn r8707) -Codechange: Turn IsValidStation into a method of Station 2007-02-13 15:42:52 +00:00
celestar
6f68ac46b8 (svn r8705) -Codechange: Increased the number of airport blocks to 64. This involves changing the enum of airport blocks to a static const uint64 as SOME platforms do not support 64-bit enums 2007-02-13 12:34:54 +00:00
rubidium
a419f4aeda (svn r8698) -Codechange: enumify the returns of VehicleEnterTile 2007-02-13 10:26:53 +00:00
rubidium
eab6dd9898 (svn r8694) -Codechange: make RoadStop's status accessible via accessor functions. 2007-02-13 00:25:42 +00:00
rubidium
6bbbedc8cc (svn r8635) -Fix: draw canal edges under buoys that are in a canal. 2007-02-08 14:04:02 +00:00
rubidium
d95a872579 (svn r8619) -Fix: store the ownership of a water tile in the buoy tile and set the ownership of the water tile when the buoy is removed. This solves the issue of removing ownership from canal tiles thus making is possible for other players to remove the canal tile. 2007-02-07 17:52:21 +00:00
KUDr
e66028538a (svn r8540) -Fix[YAPF]: Assert when buoy is placed on NE or NW map edge (Dan) 2007-02-02 20:20:56 +00:00
tron
4216c10eb1 (svn r8539) -Fix
static
2007-02-02 19:09:54 +00:00
tron
be26fbcbb3 (svn r8531) -Fix
Remove unnecessary pointer mumbo-jumbo from FindRoadStopSpot()
2007-02-02 08:23:48 +00:00
celestar
90528dc78e (svn r8528) -Codechange: Rename IsBuoy_() to IsBuoy() now that the naming conflict no longer exists. 2007-02-02 07:48:06 +00:00
celestar
5678febfe2 (svn r8514) -Codechange: Turn IsBuoy into a method of stations 2007-02-01 16:48:38 +00:00
Darkvater
3c2cb4871e (svn r8507) -Codechange/Feature: Don't remove player-owned property on-load in the scenario editor. Add a button to the landscape window to do this. 2007-02-01 12:51:10 +00:00
tron
43242302e0 (svn r8499) -Fix
-Fix (?): When removing an oil rig replace the station tile by water, not bare land
2007-01-31 21:42:58 +00:00
tron
fe1691acce (svn r8477) -Fix
-Codechange: Remove the unnecessary attributes Station::{bus,lorry}_tile_obsolete by replacing them with a scan of the map for existing road stops when loading old savegames
2007-01-31 06:25:46 +00:00
tron
6e20c73c33 (svn r8476) -Fix
Remove the unused remnants of {bus,truck}_stop_status_obsolete
(though I wonder a bit why this information doesn't get converted on load *shrug*)
2007-01-31 05:08:07 +00:00
tron
5d4241db30 (svn r8475) -Fix
Remove the unused remnants of blocked_months_obsolete
2007-01-31 05:01:29 +00:00
tron
f5b41a2fbb (svn r8474) -Fix
Turn GetPrimaryRoadStop() into a method of struct Station
2007-01-31 04:34:56 +00:00
tron
e3b63e6d83 (svn r8449) -Fix
-Codechange: Remove the superfluous attribute RoadStop::prev
2007-01-28 21:54:40 +00:00
KUDr
201ba1f5c3 (svn r8414) -Codechange: Use own AutoPtrT instead of std::auto_ptr.
-Simplifies assignment from raw pointers
 -Should be harder to crash the program by incorrect assignment into it.
 -Should help with MorphOS compilation errors
2007-01-26 11:38:07 +00:00
celestar
113fa175a4 (svn r8403) -Fix (r8402): Forgot to remove an enum 2007-01-25 11:11:43 +00:00
celestar
b0a0086e7c (svn r8402) -Codechange: Move RoadStop-specific enums to the RoadStop class, and changed a one-member enum into a static const. Simplify their naming and add some doxygen-comments to RoadStop 2007-01-25 10:06:58 +00:00
tron
e85cd647e1 (svn r8400) -Fix
Simplify r8399
2007-01-25 07:11:06 +00:00
glx
35de25eec1 (svn r8399) -Fix (r8185): a new road stop was always created in CmdBuildRoadStop(), but it was not deleted if DC_EXEC flag was not set or if the station creation failed 2007-01-25 01:29:24 +00:00