From e6b788591deab09e82f34fd11243542b1f16c904 Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Sat, 16 Feb 2019 19:53:06 +0000 Subject: [PATCH] Fix 1 byte buffer over-read in old gamelog loader --- src/saveload/gamelog_sl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/saveload/gamelog_sl.cpp b/src/saveload/gamelog_sl.cpp index 249395fe20..2626555947 100644 --- a/src/saveload/gamelog_sl.cpp +++ b/src/saveload/gamelog_sl.cpp @@ -136,7 +136,7 @@ static void Load_GLOG_common(LoggedAction *&gamelog_action, uint &gamelog_action SlObject(lc, _glog_desc[ct]); if (ct == GLCT_REVISION && SlXvIsFeatureMissing(XSLFI_EXTENDED_GAMELOG)) { - lc->revision.text = stredup(old_revision_text); + lc->revision.text = stredup(old_revision_text, lastof(old_revision_text)); } } }