Fix #8050: ending-year of 5000000 allows you to get to year 5000001 and beyond

MAX_YEAR is set to 5000000, but having an ending-year set to the
same meant you could bypass this, and play till the uint32 wrapped.

The game can either show highscore or wrap year, not both. When
you would do both, every year you get the highscore dialog.

By changing the maximum value of ending-year to 4999999 we prevent
this issue.
This commit is contained in:
Patric Stout 2021-01-07 08:40:27 +01:00 committed by Patric Stout
parent 9b800a96ed
commit d9ec8053d7

View File

@ -1423,7 +1423,7 @@ from = SLV_ENDING_YEAR
guiflags = SGF_0ISDISABLED
def = DEF_END_YEAR
min = MIN_YEAR
max = MAX_YEAR
max = MAX_YEAR - 1
interval = 1
str = STR_CONFIG_SETTING_ENDING_YEAR
strhelp = STR_CONFIG_SETTING_ENDING_YEAR_HELPTEXT