Archives/OpenTTD-patches
2
0
Fork 0
mirror of https://github.com/JGRennison/OpenTTD-patches.git synced 2024-11-17 21:25:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

(svn r6527) -Codechange: [depot window] added asserts to ensure that widget names, widget array and array of resize info stays the same length

Browse Source 
Really bad stuff will happen if one of them contains a different number of widgets ;)
   This is meant as a protection against incorrect additions of code rather than verifying that the current code works
This commit is contained in:
bjarni 2006-09-27 14:05:15 +00:00
parent 1da48c9037
commit cda35f1355
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
depot_gui.c
View File

@ -56,6 +56,7 @@ typedef enum DepotWindowWidgets {
DEPOT_WIDGET_CLONE, DEPOT_WIDGET_CLONE,
DEPOT_WIDGET_LOCATION, DEPOT_WIDGET_LOCATION,
DEPOT_WIDGET_RESIZE, DEPOT_WIDGET_RESIZE,
DEPOT_WIDGET_LAST, // used to assert if DepotWindowWidgets and widget_moves got different lengths. Due to this usage, it needs to be last
} DepotWindowWidget; } DepotWindowWidget;
/* Define how to move each widget. The order is important */ /* Define how to move each widget. The order is important */
@ -738,6 +739,10 @@ void ShowDepotWindow(TileIndex tile, byte type)
{ {
Window *w; Window *w;
/* First we ensure that the widget counts are equal in all 3 lists to prevent bad stuff from happening */
assert(lengthof(widget_moves) == lengthof(_depot_widgets));
assert(lengthof(widget_moves) == DEPOT_WIDGET_LAST);
switch (type) { switch (type) {
case VEH_Train: w = AllocateWindowDescFront(&_train_depot_desc, tile); break; case VEH_Train: w = AllocateWindowDescFront(&_train_depot_desc, tile); break;
case VEH_Road: w = AllocateWindowDescFront(&_road_depot_desc, tile); break; case VEH_Road: w = AllocateWindowDescFront(&_road_depot_desc, tile); break;