mirror of
https://github.com/JGRennison/OpenTTD-patches.git
synced 2024-11-16 00:12:51 +00:00
(svn r13489) -Fix: first determine where to *exactly* build a house before asking a NewGRF whether the location is good instead of possibly moving the house a tile after the NewGRF said the location is good.
This commit is contained in:
parent
fe6f09e66e
commit
c97a045f57
@ -1929,11 +1929,6 @@ static bool BuildTownHouse(Town *t, TileIndex tile)
|
||||
}
|
||||
|
||||
if ((hs->extra_flags & BUILDING_IS_HISTORICAL) && !_generating_world) continue;
|
||||
|
||||
if (HasBit(hs->callback_mask, CBM_HOUSE_ALLOW_CONSTRUCTION)) {
|
||||
uint16 callback_res = GetHouseCallback(CBID_HOUSE_ALLOW_CONSTRUCTION, 0, 0, house, t, tile);
|
||||
if (callback_res != CALLBACK_FAILED && GB(callback_res, 0, 8) == 0) continue;
|
||||
}
|
||||
}
|
||||
|
||||
if (_cur_year < hs->min_year || _cur_year > hs->max_year) continue;
|
||||
@ -1947,7 +1942,7 @@ static bool BuildTownHouse(Town *t, TileIndex tile)
|
||||
SetBit(oneof, TOWN_HAS_STADIUM);
|
||||
}
|
||||
|
||||
if (HASBITS(t->flags12 , oneof)) continue;
|
||||
if (HASBITS(t->flags12, oneof)) continue;
|
||||
|
||||
/* Make sure there is no slope? */
|
||||
bool noslope = (hs->building_flags & TILE_NOT_SLOPED) != 0;
|
||||
@ -1963,6 +1958,11 @@ static bool BuildTownHouse(Town *t, TileIndex tile)
|
||||
/* 1x1 house checks are already done */
|
||||
}
|
||||
|
||||
if (HasBit(hs->callback_mask, CBM_HOUSE_ALLOW_CONSTRUCTION)) {
|
||||
uint16 callback_res = GetHouseCallback(CBID_HOUSE_ALLOW_CONSTRUCTION, 0, 0, house, t, tile);
|
||||
if (callback_res != CALLBACK_FAILED && GB(callback_res, 0, 8) == 0) continue;
|
||||
}
|
||||
|
||||
/* build the house */
|
||||
t->num_houses++;
|
||||
IncreaseBuildingCount(t, house);
|
||||
|
Loading…
Reference in New Issue
Block a user