diff --git a/src/console_cmds.cpp b/src/console_cmds.cpp index 19c7ed0c8a..8519c0d217 100644 --- a/src/console_cmds.cpp +++ b/src/console_cmds.cpp @@ -1899,7 +1899,7 @@ static void OutputContentState(const ContentInfo *const ci) static const char * const states[] = { "Not selected", "Selected", "Dep Selected", "Installed", "Unknown" }; static const TextColour state_to_colour[] = { CC_COMMAND, CC_INFO, CC_INFO, CC_WHITE, CC_ERROR }; - IConsolePrint(state_to_colour[ci->state], "{}, {}, {}, {}, {:08X}, {}", ci->id, types[ci->type - 1], states[ci->state], ci->name, ci->unique_id, MD5SumToString(ci->md5sum)); + IConsolePrint(state_to_colour[ci->state], "{}, {}, {}, {}, {:08X}, {}", ci->id, types[ci->type - 1], states[ci->state], ci->name, ci->unique_id, FormatArrayAsHex(ci->md5sum)); } DEF_CONSOLE_CMD(ConContent) diff --git a/src/gamelog.cpp b/src/gamelog.cpp index 30e65d543a..05ae5f4ff4 100644 --- a/src/gamelog.cpp +++ b/src/gamelog.cpp @@ -109,7 +109,7 @@ void Gamelog::Reset() static void AddGrfInfo(std::back_insert_iterator &output_iterator, uint32_t grfid, const MD5Hash *md5sum, const GRFConfig *gc) { if (md5sum != nullptr) { - fmt::format_to(output_iterator, "GRF ID {:08X}, checksum {}", BSWAP32(grfid), MD5SumToString(*md5sum)); + fmt::format_to(output_iterator, "GRF ID {:08X}, checksum {}", BSWAP32(grfid), FormatArrayAsHex(*md5sum)); } else { fmt::format_to(output_iterator, "GRF ID {:08X}", BSWAP32(grfid)); } diff --git a/src/misc.cpp b/src/misc.cpp index d2d645f059..a22abe3121 100644 --- a/src/misc.cpp +++ b/src/misc.cpp @@ -81,7 +81,7 @@ std::string GenerateUid(std::string_view subject) checksum.Append(coding_string.c_str(), coding_string.length()); checksum.Finish(digest); - return MD5SumToString(digest); + return FormatArrayAsHex(digest); } /** diff --git a/src/network/network.cpp b/src/network/network.cpp index 2b86cec4fc..561c1df7fd 100644 --- a/src/network/network.cpp +++ b/src/network/network.cpp @@ -197,7 +197,7 @@ std::string GenerateCompanyPasswordHash(const std::string &password, const std:: checksum.Append(salted_password_string.data(), salted_password_string.size()); checksum.Finish(digest); - return MD5SumToString(digest); + return FormatArrayAsHex(digest); } /** diff --git a/src/network/network_client.cpp b/src/network/network_client.cpp index 8ba9f30d06..6c14acc5f1 100644 --- a/src/network/network_client.cpp +++ b/src/network/network_client.cpp @@ -666,7 +666,7 @@ NetworkRecvStatus ClientNetworkGameSocketHandler::Receive_SERVER_CHECK_NEWGRFS(P const GRFConfig *f = FindGRFConfig(c.grfid, FGCM_EXACT, &c.md5sum); if (f == nullptr) { /* We do not know this GRF, bail out of initialization */ - Debug(grf, 0, "NewGRF {:08X} not found; checksum {}", BSWAP32(c.grfid), MD5SumToString(c.md5sum)); + Debug(grf, 0, "NewGRF {:08X} not found; checksum {}", BSWAP32(c.grfid), FormatArrayAsHex(c.md5sum)); ret = NETWORK_RECV_STATUS_NEWGRF_MISMATCH; } } diff --git a/src/network/network_content_gui.cpp b/src/network/network_content_gui.cpp index ff049d2d58..f82b807c62 100644 --- a/src/network/network_content_gui.cpp +++ b/src/network/network_content_gui.cpp @@ -365,7 +365,7 @@ class NetworkContentListWindow : public Window, ContentCallback { if (!first) url.push_back(','); first = false; - fmt::format_to(std::back_inserter(url), "{:08X}:{}", ci->unique_id, MD5SumToString(ci->md5sum)); + fmt::format_to(std::back_inserter(url), "{:08X}:{}", ci->unique_id, FormatArrayAsHex(ci->md5sum)); } } else { url += "do=searchtext&q="; diff --git a/src/network/network_survey.cpp b/src/network/network_survey.cpp index aa9aa84f11..3f21fdca71 100644 --- a/src/network/network_survey.cpp +++ b/src/network/network_survey.cpp @@ -268,7 +268,7 @@ static void SurveyGrfs(nlohmann::json &survey) auto grfid = fmt::format("{:08x}", BSWAP32(c->ident.grfid)); auto &grf = survey[grfid]; - grf["md5sum"] = MD5SumToString(c->ident.md5sum); + grf["md5sum"] = FormatArrayAsHex(c->ident.md5sum); grf["status"] = c->status; if ((c->palette & GRFP_GRF_MASK) == GRFP_GRF_UNSET) grf["palette"] = "unset"; diff --git a/src/newgrf_config.cpp b/src/newgrf_config.cpp index f596e64f77..235d49a73d 100644 --- a/src/newgrf_config.cpp +++ b/src/newgrf_config.cpp @@ -481,7 +481,7 @@ GRFListCompatibility IsGoodGRFConfigList(GRFConfig *grfconfig) * same grfid, as it most likely is compatible */ f = FindGRFConfig(c->ident.grfid, FGCM_COMPATIBLE, nullptr, c->version); if (f != nullptr) { - Debug(grf, 1, "NewGRF {:08X} ({}) not found; checksum {}. Compatibility mode on", BSWAP32(c->ident.grfid), c->filename, MD5SumToString(c->ident.md5sum)); + Debug(grf, 1, "NewGRF {:08X} ({}) not found; checksum {}. Compatibility mode on", BSWAP32(c->ident.grfid), c->filename, FormatArrayAsHex(c->ident.md5sum)); if (!HasBit(c->flags, GCF_COMPATIBLE)) { /* Preserve original_md5sum after it has been assigned */ SetBit(c->flags, GCF_COMPATIBLE); @@ -494,7 +494,7 @@ GRFListCompatibility IsGoodGRFConfigList(GRFConfig *grfconfig) } /* No compatible grf was found, mark it as disabled */ - Debug(grf, 0, "NewGRF {:08X} ({}) not found; checksum {}", BSWAP32(c->ident.grfid), c->filename, MD5SumToString(c->ident.md5sum)); + Debug(grf, 0, "NewGRF {:08X} ({}) not found; checksum {}", BSWAP32(c->ident.grfid), c->filename, FormatArrayAsHex(c->ident.md5sum)); c->status = GCS_NOT_FOUND; res = GLC_NOT_FOUND; diff --git a/src/newgrf_gui.cpp b/src/newgrf_gui.cpp index 438413f6a5..da26d62f36 100644 --- a/src/newgrf_gui.cpp +++ b/src/newgrf_gui.cpp @@ -105,7 +105,7 @@ static void ShowNewGRFInfo(const GRFConfig *c, const Rect &r, bool show_params) } /* Prepare and draw MD5 sum */ - tmp = MD5SumToString(c->ident.md5sum); + tmp = FormatArrayAsHex(c->ident.md5sum); SetDParamStr(0, tmp); tr.top = DrawStringMultiLine(tr, STR_NEWGRF_SETTINGS_MD5SUM); diff --git a/src/openttd.cpp b/src/openttd.cpp index 168d82bcb9..6444d410b9 100644 --- a/src/openttd.cpp +++ b/src/openttd.cpp @@ -258,7 +258,7 @@ static void WriteSavegameInfo(const char *name) if (_load_check_data.HasNewGrfs()) { for (GRFConfig *c = _load_check_data.grfconfig; c != nullptr; c = c->next) { fmt::format_to(std::back_inserter(message), "{:08X} {} {}\n", c->ident.grfid, - MD5SumToString(HasBit(c->flags, GCF_COMPATIBLE) ? c->original_md5sum : c->ident.md5sum), c->filename); + FormatArrayAsHex(HasBit(c->flags, GCF_COMPATIBLE) ? c->original_md5sum : c->ident.md5sum), c->filename); } } diff --git a/src/saveload/afterload.cpp b/src/saveload/afterload.cpp index 15213ca7d0..7cdd8dbb0b 100644 --- a/src/saveload/afterload.cpp +++ b/src/saveload/afterload.cpp @@ -389,11 +389,11 @@ static void CDECL HandleSavegameLoadCrash(int signum) if (HasBit(c->flags, GCF_COMPATIBLE)) { const GRFIdentifier *replaced = _gamelog.GetOverriddenIdentifier(c); fmt::format_to(std::back_inserter(message), "NewGRF {:08X} (checksum {}) not found.\n Loaded NewGRF \"{}\" (checksum {}) with same GRF ID instead.\n", - BSWAP32(c->ident.grfid), MD5SumToString(c->original_md5sum), c->filename, MD5SumToString(replaced->md5sum)); + BSWAP32(c->ident.grfid), FormatArrayAsHex(c->original_md5sum), c->filename, FormatArrayAsHex(replaced->md5sum)); } if (c->status == GCS_NOT_FOUND) { fmt::format_to(std::back_inserter(message), "NewGRF {:08X} ({}) not found; checksum {}.\n", - BSWAP32(c->ident.grfid), c->filename, MD5SumToString(c->ident.md5sum)); + BSWAP32(c->ident.grfid), c->filename, FormatArrayAsHex(c->ident.md5sum)); } } } else { diff --git a/src/screenshot.cpp b/src/screenshot.cpp index 2f3a8257cb..8d853c52dc 100644 --- a/src/screenshot.cpp +++ b/src/screenshot.cpp @@ -320,7 +320,7 @@ static bool MakePNGImage(const char *name, ScreenshotCallback *callb, void *user fmt::format_to(std::back_inserter(message), "Graphics set: {} ({})\n", BaseGraphics::GetUsedSet()->name, BaseGraphics::GetUsedSet()->version); message += "NewGRFs:\n"; for (const GRFConfig *c = _game_mode == GM_MENU ? nullptr : _grfconfig; c != nullptr; c = c->next) { - fmt::format_to(std::back_inserter(message), "{:08X} {} {}\n", BSWAP32(c->ident.grfid), MD5SumToString(c->ident.md5sum), c->filename); + fmt::format_to(std::back_inserter(message), "{:08X} {} {}\n", BSWAP32(c->ident.grfid), FormatArrayAsHex(c->ident.md5sum), c->filename); } message += "\nCompanies:\n"; for (const Company *c : Company::Iterate()) { diff --git a/src/settings.cpp b/src/settings.cpp index b280a5204e..7843714889 100644 --- a/src/settings.cpp +++ b/src/settings.cpp @@ -1140,7 +1140,7 @@ static void GRFSaveConfig(IniFile &ini, const char *grpname, const GRFConfig *li GRFBuildParamList(params, c, lastof(params)); std::string key = fmt::format("{:08X}|{}|{}", BSWAP32(c->ident.grfid), - MD5SumToString(c->ident.md5sum), c->filename); + FormatArrayAsHex(c->ident.md5sum), c->filename); group->GetItem(key, true)->SetValue(params); } } diff --git a/src/string.cpp b/src/string.cpp index 2f8174eb4e..f55ebfbe24 100644 --- a/src/string.cpp +++ b/src/string.cpp @@ -613,17 +613,6 @@ int CDECL seprintf(char *str, const char *last, const char *format, ...) } -/** - * Convert the md5sum to a hexadecimal string representation - * @param md5sum the md5sum itself - * @return the string representation of the md5sum. - */ -std::string MD5SumToString(const MD5Hash &md5sum) -{ - return FormatArrayAsHex(md5sum); -} - - /* UTF-8 handling routines */ diff --git a/src/string_func.h b/src/string_func.h index dd6a10341a..914cd064c3 100644 --- a/src/string_func.h +++ b/src/string_func.h @@ -29,7 +29,6 @@ #include "core/bitmath_func.hpp" #include "core/span_type.hpp" #include "string_type.h" -#include "3rdparty/md5/md5.h" char *strecat(char *dst, const char *src, const char *last) NOACCESS(3); char *strecpy(char *dst, const char *src, const char *last) NOACCESS(3); @@ -91,8 +90,6 @@ static inline size_t ttd_strnlen(const char *str, size_t maxlen) return t - str; } -std::string MD5SumToString(const MD5Hash &md5sum); - bool IsValidChar(WChar key, CharSetFilter afilter); size_t Utf8Decode(WChar *c, const char *s);