Archives/OpenTTD-patches
2
0
Fork 0
mirror of https://github.com/JGRennison/OpenTTD-patches.git synced 2024-11-17 21:25:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

(svn r2619) Fix: [viewport] Fix potential buffer overflow reported by Tron

Browse Source
This commit is contained in:
ludde 2005-07-17 18:36:47 +00:00
parent 39c9b8a665
commit abc9376308
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
viewport.c
View File

@ -61,6 +61,10 @@ typedef struct ParentSpriteToDraw {
byte tile_z_bottom;
} ParentSpriteToDraw;
// Quick hack to know how much memory to reserve when allocating from the spritelist
// to prevent a buffer overflow.
#define LARGEST_SPRITELIST_STRUCT ParentSpriteToDraw
typedef struct ViewportDrawer {
DrawPixelInfo dpi;
@ -1236,7 +1240,7 @@ void ViewportDoDraw(const ViewPort *vp, int left, int top, int right, int bottom
vd.parent_list = parent_list;
vd.eof_parent_list = &parent_list[lengthof(parent_list)];
vd.spritelist_mem = mem;
vd.eof_spritelist_mem = &mem[sizeof(mem) - 0x40];
vd.eof_spritelist_mem = &mem[sizeof(mem) - sizeof(LARGEST_SPRITELIST_STRUCT)];
vd.last_string = &vd.first_string;
vd.first_string = NULL;
vd.last_tile = &vd.first_tile;