From 8b0e4bb10170d8eeb882f0fcc0ad58e80d751027 Mon Sep 17 00:00:00 2001 From: Samu Date: Thu, 9 Jan 2020 13:42:35 +0000 Subject: [PATCH] Codechange: Use const instead of magic number for vehicle profit threshold --- src/group_gui.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/group_gui.cpp b/src/group_gui.cpp index 842e3fbb0e..e28e10bb2c 100644 --- a/src/group_gui.cpp +++ b/src/group_gui.cpp @@ -299,7 +299,7 @@ private: spr = SPR_PROFIT_NA; } else if (profit_last_year < 0) { spr = SPR_PROFIT_NEGATIVE; - } else if (profit_last_year < (Money)10000 * num_profit_vehicle) { // TODO magic number + } else if (profit_last_year < VEHICLE_PROFIT_THRESHOLD * num_profit_vehicle) { spr = SPR_PROFIT_SOME; } else { spr = SPR_PROFIT_LOT;