From 8a33e988340e6a4021e18f1c7b412c8ce53572fb Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Sat, 19 Jun 2021 22:31:23 +0100 Subject: [PATCH] Fix #8169: nullptr dereference when autoreplacing vehicle with no orders (#9387) --- src/autoreplace_cmd.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/autoreplace_cmd.cpp b/src/autoreplace_cmd.cpp index 9e82944b64..4f9cf92bb4 100644 --- a/src/autoreplace_cmd.cpp +++ b/src/autoreplace_cmd.cpp @@ -207,6 +207,7 @@ static int GetIncompatibleRefitOrderIdForAutoreplace(const Vehicle *v, EngineID const Vehicle *u = (v->type == VEH_TRAIN) ? v->First() : v; const OrderList *orders = u->orders.list; + if (orders == nullptr) return -1; for (VehicleOrderID i = 0; i < orders->GetNumOrders(); i++) { o = orders->GetOrderAt(i); if (!o->IsRefit()) continue;