Fix banding issue in artic tree range

Using tile index for randomization is a very very very bad idea
3 years ago · 6c2152045a
parent 3b4cbd3323
commit 6c2152045a
1 changed files with 1 additions and 2 deletions
--- a/src/tree_cmd.cpp
+++ b/src/tree_cmd.cpp
@ -194,8 +194,7 @@ static TreeType GetRandomTreeType(TileIndex tile, uint seed)
 			uint normalised_distance = (height_above_snow_line < 0) ? -height_above_snow_line : height_above_snow_line + 1;
 			bool arctic_tree = false;
 			if (normalised_distance < lengthof(_arctic_tree_occurance)) {
-				uint adjusted_seed = (seed ^ tile) & 0xFF;
-				arctic_tree = adjusted_seed < _arctic_tree_occurance[normalised_distance];
+				arctic_tree = RandomRange(256) < _arctic_tree_occurance[normalised_distance];
 			}
 			if (height_above_snow_line < 0) {
 				/* Below snow level mixed forest. */