(svn r1358) Assert bounds of depot list when searching for a depot

roadveh_gui.c

@@ -512,7 +512,9 @@ static void DrawRoadDepotWindow(Window *w)
 	SetVScrollCount(w, (num + w->hscroll.cap - 1) / w->hscroll.cap);
 
 	/* locate the depot struct */
-	for(d=_depots; d->xy != (TileIndex)tile; d++) {}
+	for (d = _depots; d->xy != (TileIndex)tile; d++) {
+		assert(d < endof(_depots);
+	}
 
 	SetDParam(0, d->town_index);
 	DrawWindowWidgets(w);

ship_gui.c

@@ -646,7 +646,9 @@ static void DrawShipDepotWindow(Window *w)
 	SetVScrollCount(w, (num + w->hscroll.cap - 1) / w->hscroll.cap);
 
 	/* locate the depot struct */
-	for(d=_depots; d->xy != (TileIndex)tile; d++) {}
+	for (d = _depots; d->xy != (TileIndex)tile; d++) {
+		assert(d < endof(_depots);
+	}
 
 	SetDParam(0, d->town_index);
 	DrawWindowWidgets(w);

train_gui.c

@@ -333,7 +333,9 @@ static void DrawTrainDepotWindow(Window *w)
 	SetHScrollCount(w, hnum);
 
 	/* locate the depot struct */
-	for(d=_depots; d->xy != (TileIndex)tile; d++) {}
+	for (d = _depots; d->xy != (TileIndex)tile; d++) {
+		assert(d < endof(_depots);
+	}
 
 	SetDParam(0, d->town_index);
 	DrawWindowWidgets(w);