From 2080daab8d454a8b2505fdaff198222620d20a72 Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Wed, 8 Feb 2017 19:47:37 +0000 Subject: [PATCH] Linkgraph: Refactoring to avoid manual deletes. --- src/linkgraph/linkgraphschedule.cpp | 15 ++++++--------- src/linkgraph/linkgraphschedule.h | 2 +- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/linkgraph/linkgraphschedule.cpp b/src/linkgraph/linkgraphschedule.cpp index bf9119eaab..840f541e6a 100644 --- a/src/linkgraph/linkgraphschedule.cpp +++ b/src/linkgraph/linkgraphschedule.cpp @@ -212,12 +212,12 @@ void LinkGraphSchedule::ShiftDates(int interval) */ LinkGraphSchedule::LinkGraphSchedule() { - this->handlers[0] = new InitHandler; - this->handlers[1] = new DemandHandler; - this->handlers[2] = new MCFHandler; - this->handlers[3] = new FlowMapper(false); - this->handlers[4] = new MCFHandler; - this->handlers[5] = new FlowMapper(true); + this->handlers[0].reset(new InitHandler); + this->handlers[1].reset(new DemandHandler); + this->handlers[2].reset(new MCFHandler); + this->handlers[3].reset(new FlowMapper(false)); + this->handlers[4].reset(new MCFHandler); + this->handlers[5].reset(new FlowMapper(true)); } /** @@ -226,9 +226,6 @@ LinkGraphSchedule::LinkGraphSchedule() LinkGraphSchedule::~LinkGraphSchedule() { this->Clear(); - for (uint i = 0; i < lengthof(this->handlers); ++i) { - delete this->handlers[i]; - } } LinkGraphJobGroup::LinkGraphJobGroup(constructor_token token, std::vector jobs) : diff --git a/src/linkgraph/linkgraphschedule.h b/src/linkgraph/linkgraphschedule.h index 9a9d7f17af..cebd974893 100644 --- a/src/linkgraph/linkgraphschedule.h +++ b/src/linkgraph/linkgraphschedule.h @@ -46,7 +46,7 @@ private: friend const SaveLoad *GetLinkGraphScheduleDesc(); protected: - ComponentHandler *handlers[6]; ///< Handlers to be run for each job. + std::unique_ptr handlers[6]; ///< Handlers to be run for each job. GraphList schedule; ///< Queue for new jobs. JobList running; ///< Currently running jobs.