diff --git a/src/network/core/tcp_content.cpp b/src/network/core/tcp_content.cpp index 897570a91b..b5bf529990 100644 --- a/src/network/core/tcp_content.cpp +++ b/src/network/core/tcp_content.cpp @@ -27,6 +27,21 @@ ContentInfo::~ContentInfo() free(this->tags); } +/** + * Copy data from other #ContentInfo and take ownership of allocated stuff. + * @param other Source to copy from. #dependencies and #tags will be NULLed. + */ +void ContentInfo::TransferFrom(ContentInfo *other) +{ + if (other != this) { + free(this->dependencies); + free(this->tags); + memcpy(this, other, sizeof(ContentInfo)); + other->dependencies = NULL; + other->tags = NULL; + } +} + size_t ContentInfo::Size() const { size_t len = 0; diff --git a/src/network/core/tcp_content.h b/src/network/core/tcp_content.h index 3b82696df7..24b87f16f8 100644 --- a/src/network/core/tcp_content.h +++ b/src/network/core/tcp_content.h @@ -88,6 +88,8 @@ struct ContentInfo { /** Free everything allocated */ ~ContentInfo(); + void TransferFrom(ContentInfo *other); + /** * Get the size of the data as send over the network. * @return the size. diff --git a/src/network/network_content.cpp b/src/network/network_content.cpp index f70f0e7246..a7032a60fc 100644 --- a/src/network/network_content.cpp +++ b/src/network/network_content.cpp @@ -135,15 +135,13 @@ DEF_CONTENT_RECEIVE_COMMAND(Client, PACKET_CONTENT_SERVER_INFO) /* * As ici might be selected by the content window we cannot delete that. * However, we want to keep most of the values of ci, except the values - * we (just) already preserved. As there are already allocated blobs of - * memory and more may be added, we cannot simply copy ci to ici as that - * might cause a leak of memory. As such we need to swap the data and - * then delete the memory we allocated here. + * we (just) already preserved. + * So transfer data and ownership of allocated memory from ci to ici. */ - Swap(*ici, *ci); + ici->TransferFrom(ci); delete ci; - this->OnReceiveContentInfo(ci); + this->OnReceiveContentInfo(ici); return true; } }