Fix: [Network] Check on CIDR for netmask check considered everything valid

3 years ago · 031e91de6e
parent e6f0d63e25
commit 031e91de6e
1 changed files with 1 additions and 1 deletions
--- a/src/network/core/address.cpp
+++ b/src/network/core/address.cpp
@ -170,7 +170,7 @@ bool NetworkAddress::IsInNetmask(const char *netmask)
 		int tmp_cidr = atoi(chr_cidr + 1);

 		/* Invalid CIDR, treat as single host */
-		if (tmp_cidr > 0 || tmp_cidr < cidr) cidr = tmp_cidr;
+		if (tmp_cidr > 0 && tmp_cidr < cidr) cidr = tmp_cidr;

 		/* Remove the / so that NetworkAddress works on the IP portion */
 		std::string ip_str(netmask, chr_cidr - netmask);