From 58f18082d6d6941df2014458cdbf05b014355e9b Mon Sep 17 00:00:00 2001
From: Christopher Roy Bratusek <nano@jpberlin.de>
Date: Wed, 31 Oct 2018 20:54:15 +0100
Subject: [PATCH] split permissions file for better granulation; add
 privapp-permission for BackupTransport

---
 .../permissions/privapp-permissions-gsync.xml |  7 +++
 .../microg-permissions.xml                    | 13 ------
 .../phonesky-permissions.xml                  | 44 +++++++++++++++++++
 .../privapp-permissions-microg.xml            |  7 +++
 ...e.xml => privapp-permissions-phonesky.xml} |  5 ---
 5 files changed, 58 insertions(+), 18 deletions(-)
 create mode 100644 Full/gsync/etc/permissions/privapp-permissions-gsync.xml
 create mode 100644 Full/system/etc/default-permissions/phonesky-permissions.xml
 create mode 100644 Full/system/etc/permissions/privapp-permissions-microg.xml
 rename Full/system/etc/permissions/{privapp-permissions-google.xml => privapp-permissions-phonesky.xml} (87%)

diff --git a/Full/gsync/etc/permissions/privapp-permissions-gsync.xml b/Full/gsync/etc/permissions/privapp-permissions-gsync.xml
new file mode 100644
index 0000000..0d972e8
--- /dev/null
+++ b/Full/gsync/etc/permissions/privapp-permissions-gsync.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<permissions>
+	<privapp-permissions package="com.google.android.backuptransport">
+		<permission name="android.permission.BACKUP"/>
+		<permission name="android.permission.UPDATE_DEVICE_STATS"/>
+	</privapp-permissions>
+</permissions>
diff --git a/Full/system/etc/default-permissions/microg-permissions.xml b/Full/system/etc/default-permissions/microg-permissions.xml
index dbe8143..b1356ad 100644
--- a/Full/system/etc/default-permissions/microg-permissions.xml
+++ b/Full/system/etc/default-permissions/microg-permissions.xml
@@ -42,19 +42,6 @@
         <permission name="android.permission.WRITE_EXTERNAL_STORAGE" fixed="false"></permission>
     </exception>
 
-    <exception package="com.android.vending">
-        <!-- Phone -->
-        <permission name="android.permission.READ_PHONE_STATE" fixed="false"></permission>
-        <!-- Account -->
-        <permission name="android.permission.GET_ACCOUNTS" fixed="false"></permission>
-        <!-- Location -->
-        <permission name="android.permission.ACCESS_FINE_LOCATION" fixed="false"></permission>
-        <permission name="android.permission.ACCESS_COARSE_LOCATION" fixed="false"></permission>
-        <!-- Storage -->
-        <permission name="android.permission.READ_EXTERNAL_STORAGE" fixed="false"></permission>
-        <permission name="android.permission.WRITE_EXTERNAL_STORAGE" fixed="false"></permission>
-    </exception>
-
     <exception package="org.microg.nlp.backend.ichnaea">
         <permission name="android.permission.ACCESS_COARSE_LOCATION" fixed="false"></permission>
         <permission name="android.permission.ACCESS_FINE_LOCATION" fixed="false"></permission>
diff --git a/Full/system/etc/default-permissions/phonesky-permissions.xml b/Full/system/etc/default-permissions/phonesky-permissions.xml
new file mode 100644
index 0000000..e248693
--- /dev/null
+++ b/Full/system/etc/default-permissions/phonesky-permissions.xml
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright (C) 2017  ale5000
+     This file was created by ale5000 (ale5000-git on GitHub).
+
+     This program is free software: you can redistribute it and/or modify
+     it under the terms of the GNU General Public License as published by
+     the Free Software Foundation, either version 3 of the License, or
+     (at your option) any later version, w/ zip exception.
+
+     This program is distributed in the hope that it will be useful,
+     but WITHOUT ANY WARRANTY; without even the implied warranty of
+     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+     GNU General Public License for more details.
+
+     You should have received a copy of the GNU General Public License
+     along with this program.  If not, see <https://www.gnu.org/licenses/>.
+-->
+
+<!-- This file contains permissions to be granted by default.
+     Default permissions are granted to special platform components and to apps
+     that are approved to get default grants.
+     The special components are apps that are expected to work out-of-the-box
+     as they provide core use cases. These grants are managed by the platform.
+     Fixed permissions cannot be controlled by the user and need a special
+     approval. Typically these are to ensure either legally mandated functions
+     or the app is considered a part of the OS.
+
+     Granting these permissions could prevent issues on some ROMs or
+     on non-clean installations.
+-->
+<exceptions>
+        <exception package="com.android.vending">
+        <!-- Phone -->
+        <permission name="android.permission.READ_PHONE_STATE" fixed="false"></permission>
+        <!-- Account -->
+        <permission name="android.permission.GET_ACCOUNTS" fixed="false"></permission>
+        <!-- Location -->
+        <permission name="android.permission.ACCESS_FINE_LOCATION" fixed="false"></permission>
+        <permission name="android.permission.ACCESS_COARSE_LOCATION" fixed="false"></permission>
+        <!-- Storage -->
+        <permission name="android.permission.READ_EXTERNAL_STORAGE" fixed="false"></permission>
+        <permission name="android.permission.WRITE_EXTERNAL_STORAGE" fixed="false"></permission>
+    </exception>
+</exceptions>
diff --git a/Full/system/etc/permissions/privapp-permissions-microg.xml b/Full/system/etc/permissions/privapp-permissions-microg.xml
new file mode 100644
index 0000000..9d65827
--- /dev/null
+++ b/Full/system/etc/permissions/privapp-permissions-microg.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<permissions>
+	<privapp-permissions package="com.google.android.gms">
+		<permission name="android.permission.CHANGE_DEVICE_IDLE_TEMP_WHITELIST"/>
+		<permission name="android.permission.INSTALL_LOCATION_PROVIDER"/>
+	</privapp-permissions>
+</permissions>
diff --git a/Full/system/etc/permissions/privapp-permissions-google.xml b/Full/system/etc/permissions/privapp-permissions-phonesky.xml
similarity index 87%
rename from Full/system/etc/permissions/privapp-permissions-google.xml
rename to Full/system/etc/permissions/privapp-permissions-phonesky.xml
index 0cece92..0518866 100644
--- a/Full/system/etc/permissions/privapp-permissions-google.xml
+++ b/Full/system/etc/permissions/privapp-permissions-phonesky.xml
@@ -1,10 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <permissions>
-	<privapp-permissions package="com.google.android.gms">
-		<permission name="android.permission.CHANGE_DEVICE_IDLE_TEMP_WHITELIST"/>
-		<permission name="android.permission.INSTALL_LOCATION_PROVIDER"/>
-	</privapp-permissions>
-
 	<privapp-permissions package="com.android.vending">
 		<permission name="android.permission.ALLOCATE_AGGRESSIVE"/>
 		<permission name="android.permission.BACKUP"/>