From b0b12856d54459773f0fcc936c7c609d80904651 Mon Sep 17 00:00:00 2001 From: ajaythapliyal Date: Tue, 7 Mar 2023 09:27:26 +0530 Subject: [PATCH 1/2] makes the outline of feedback icon consistent with the inner color --- frontend/src/assets/dislike.svg | 4 ++-- frontend/src/assets/like.svg | 2 +- frontend/src/conversation/ConversationBubble.tsx | 10 ++++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/frontend/src/assets/dislike.svg b/frontend/src/assets/dislike.svg index 675ff97..9a51f1e 100644 --- a/frontend/src/assets/dislike.svg +++ b/frontend/src/assets/dislike.svg @@ -1,4 +1,4 @@ - + - + diff --git a/frontend/src/assets/like.svg b/frontend/src/assets/like.svg index eb43fd5..9c2902f 100644 --- a/frontend/src/assets/like.svg +++ b/frontend/src/assets/like.svg @@ -1,4 +1,4 @@ - + diff --git a/frontend/src/conversation/ConversationBubble.tsx b/frontend/src/conversation/ConversationBubble.tsx index 7bad166..82074c3 100644 --- a/frontend/src/conversation/ConversationBubble.tsx +++ b/frontend/src/conversation/ConversationBubble.tsx @@ -63,9 +63,10 @@ const ConversationBubble = forwardRef< }`} > handleFeedback?.('LIKE')} > @@ -78,9 +79,10 @@ const ConversationBubble = forwardRef< }`} > handleFeedback?.('DISLIKE')} > From d1cc91dd6f51a9e6e769423bb45a6bfa9e8bbe49 Mon Sep 17 00:00:00 2001 From: ajaythapliyal Date: Tue, 7 Mar 2023 09:44:53 +0530 Subject: [PATCH 2/2] makes feedback icon always visible for mobile --- frontend/src/conversation/ConversationBubble.tsx | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/frontend/src/conversation/ConversationBubble.tsx b/frontend/src/conversation/ConversationBubble.tsx index 82074c3..6cb5667 100644 --- a/frontend/src/conversation/ConversationBubble.tsx +++ b/frontend/src/conversation/ConversationBubble.tsx @@ -19,10 +19,6 @@ const ConversationBubble = forwardRef< ref, ) { const [showFeedback, setShowFeedback] = useState(false); - // const [overriddenFeedback, setOverriddenFeedback] = useState< - // FEEDBACK | undefined - // >(undefined); - // const effectiveFeedback = overriddenFeedback ?? feedback; let bubble; if (type === 'QUESTION') { @@ -59,7 +55,7 @@ const ConversationBubble = forwardRef< className={`mr-2 flex items-center justify-center ${ feedback === 'LIKE' || (type !== 'ERROR' && showFeedback) ? '' - : 'invisible' + : 'md:invisible' }`} >