Archives/Cloak
2
0
Fork 0
mirror of https://github.com/cbeuw/Cloak.git synced 2024-11-03 23:15:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor Makefile edit and remove FIXME

Browse Source
This commit is contained in:
Qian Wang 2019-01-12 14:16:31 +00:00
parent d906541497
commit 310ce1643a
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -7,10 +7,12 @@ version=$(shell ver=$$(git log -n 1 --pretty=oneline --format=%D | awk -F, '{pri
echo $$ver) echo $$ver)
client: client:
mkdir build
go build -ldflags "-X main.version=${version}" ./cmd/ck-client go build -ldflags "-X main.version=${version}" ./cmd/ck-client
mv ck-client* ./build mv ck-client* ./build
server: server:
mkdir build
go build -ldflags "-X main.version=${version}" ./cmd/ck-server go build -ldflags "-X main.version=${version}" ./cmd/ck-server
mv ck-server* ./build mv ck-server* ./build

11
internal/multiplex/switchboard.go
View File

@ -148,17 +148,6 @@ func (sb *switchboard) deplex(ce *connEnclave) {
continue continue
} }
// FIXME: there has been a bug in which a packet has
// a seemingly corrupted StreamID (e.g. when the largest streamID is something like 3000
// and suddently a streamID of 3358661675 is added.
// It happens once ~6 hours and the occourance is realy unstable
// I couldn't find a way to reproduce it. But I do have some clue.
// I commented out the util.genXorKeys function so that the stream headers are being
// sent in plaintext, and this bug didn't happen again. So I suspect it has to do
// with xxHash. Either it's to do with my usage of the libary or the implementation
// of the library. Maybe there's a race somewhere? I may eventually use another
// method to encrypt the headers. xxHash isn't cryptographic afterall.
stream := sb.session.getStream(frame.StreamID, frame.Closing == 1) stream := sb.session.getStream(frame.StreamID, frame.Closing == 1)
// if the frame is telling us to close a closed stream // if the frame is telling us to close a closed stream
// (this happens when ss-server and ss-local closes the stream // (this happens when ss-server and ss-local closes the stream